rpc: Reject deprecated reserveChangeKey in fundrawtransaction #12409

1. 
   MarcoFalke commented at 3:12 am on February 11, 2018: member
2. rpc: Reject deprecated reserveChangeKey in fundrawtransaction fa5f51830d
3. MarcoFalke added the label RPC/REST/ZMQ on Feb 11, 2018
4. MarcoFalke added this to the milestone 0.17.0 on Feb 11, 2018
5. randolf changes_requested
6. 
   randolf commented at 3:24 am on February 11, 2018: contributor

   Please change “rpc” to “RPC” because it’s an acronym, thanks. File: doc/release-notes.md
7. in doc/release-notes.md:60 in fa5f51830d

   55@@ -56,6 +56,13 @@ frequently tested on them.
   56 Notable changes
   57 ===============
   58 
   59+RPC changes
   60+------------
   

   ---

   ---

   

   promag commented at 10:58 am on February 11, 2018:

   Remove extra -.
8. in src/wallet/rpcwallet.cpp:3132 in fa5f51830d

   3128@@ -3129,7 +3129,6 @@ UniValue fundrawtransaction(const JSONRPCRequest& request)
   3129                 {"change_type", UniValueType(UniValue::VSTR)},
   3130                 {"includeWatching", UniValueType(UniValue::VBOOL)},
   3131                 {"lockUnspents", UniValueType(UniValue::VBOOL)},
   3132-                {"reserveChangeKey", UniValueType(UniValue::VBOOL)}, // DEPRECATED (and ignored), should be removed in 0.16 or so.
   

   ---

   ---

   

   promag commented at 11:00 am on February 11, 2018:

   Should we allow it behind IsDeprecatedRPCEnabled()?

   ---

   

   jonasschnelli commented at 9:05 am on February 12, 2018:

   I guess this move is from deprecated to removed. So IMO no need to hide it behind IsDeprecatedRPCEnabled().
9. 
   jonasschnelli commented at 9:06 am on February 12, 2018: contributor

   utACK fa5f51830d2649cace2fc827084093019497c151
10. 
    laanwj commented at 1:30 pm on February 13, 2018: member

    utACK https://github.com/bitcoin/bitcoin/commit/fa5f51830d2649cace2fc827084093019497c151, strange that we missed this in #12336.
11. 
    promag commented at 6:26 pm on February 13, 2018: member

    utACK fa5f518, strange that we missed this in #12336. @laanwj it wasn’t #12336#pullrequestreview-95040479.

12. 
    laanwj commented at 3:44 pm on February 14, 2018: member

    @laanwj it wasn’t #12336 (review).

    Oh I missed that, sorry!

13. laanwj merged this on Feb 14, 2018
14. laanwj closed this on Feb 14, 2018

    ---

15. laanwj referenced this in commit 0cc45edc0f on Feb 14, 2018
16. MarcoFalke deleted the branch on Mar 22, 2018
17. PastaPastaPasta referenced this in commit 0d7665cf59 on Jun 13, 2020
18. PastaPastaPasta referenced this in commit 785fc50622 on Jun 13, 2020
19. PastaPastaPasta referenced this in commit 3c982fbedb on Jun 14, 2020
20. PastaPastaPasta referenced this in commit c418bfa97d on Jun 17, 2020
21. PastaPastaPasta referenced this in commit 81593b643b on Jun 17, 2020
22. PastaPastaPasta referenced this in commit ee38632e2c on Jun 17, 2020
23. PastaPastaPasta referenced this in commit 2a24d84bd2 on Jun 17, 2020
24. deadalnix referenced this in commit c4a93550b0 on Nov 1, 2020
25. DrahtBot locked this on Sep 8, 2021

Contributors
MarcoFalke randolf promag jonasschnelli laanwj

Labels
RPC/REST/ZMQ

Milestone
0.17.0