Make signrawtransaction accept P2SH-P2WSH redeemscripts #12427

1. 
   sipa commented at 9:28 pm on February 13, 2018: member

   This is a quick fix for #12418, which is a regression in 0.16.

   It permits specifying just the inner redeemscript to let signrawtransaction succeed. This inner redeemscript is already reported by addmultisigaddress & co.

   #11708 uses a different approach, where listunspent reports both inner & outer redeemscript, but requires both to be provided to signrawtransaction. Part of #11708 is still needed even in combination with this PR however, as currently the inner redeemscript isn’t reported by listunspent.

2. fanquake added the label RPC/REST/ZMQ on Feb 13, 2018
3. MarcoFalke added this to the milestone 0.16.0 on Feb 13, 2018
4. sipa force-pushed on Feb 14, 2018
5. sipa force-pushed on Feb 14, 2018
6. Make signrawtransaction accept P2SH-P2WSH redeemscripts 5f605e172b
7. sipa force-pushed on Feb 14, 2018
8. laanwj added the label Needs backport on Feb 14, 2018
9. 
   Sjors commented at 1:06 pm on February 15, 2018: member

   Manually tested signrawtransaction with explicit private key arguments on regtest, with P2SH-P2WSH. Works on this branch, and throws Unable to sign input, invalid stack size on master.

   Also tested with a native P2WSH multisig for good measure. This already worked on master.

10. 
    laanwj commented at 1:30 pm on February 15, 2018: member

    utACK https://github.com/bitcoin/bitcoin/pull/12427/commits/5f605e172baee35421eb20736601befdd8cad796
11. 
    laanwj commented at 9:13 pm on February 15, 2018: member

    I do think this needs a test, but that can be done later (no need to hold up 0.16.0 for it), thanks @sjors for doing a manual test.
12. laanwj merged this on Feb 15, 2018
13. laanwj closed this on Feb 15, 2018

    ---

14. laanwj referenced this in commit 3fa556aee2 on Feb 15, 2018
15. laanwj removed the label Needs backport on Feb 15, 2018
16. laanwj referenced this in commit 3762ac127a on Feb 15, 2018
17. 
    theuni commented at 10:27 pm on February 15, 2018: member

    post-merge utACK
18. HashUnlimited referenced this in commit 036a795115 on Mar 16, 2018
19. ccebrecos referenced this in commit d8d02e45cd on Sep 14, 2018
20. laanwj referenced this in commit 3facd9fdc4 on Feb 14, 2019
21. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa Sjors laanwj theuni

Labels
RPC/REST/ZMQ

Milestone
0.16.0