Beside removing duplicates of the same args in the code, this actually helps with debugging after a test failure.
For example, bitcoin-qt has server turned off, so you'd have to turn it on every time, if you wanted to debug a temporary test datadir created by the test framework.
Also, keypool would fill up if you forget to specify -keypool=1.
Concept ACK
Tested ACK
61 | + # Most callers will just need to add extra args to the standard list below. 62 | + # For those callers that need more flexibity, they can just set the args property directly. 63 | + # Note that common args are set in the config file (see initialize_datadir) 64 | self.extra_args = extra_args 65 | - self.args = [self.binary, "-datadir=" + self.datadir, "-server", "-keypool=1", "-discover=0", "-rest", "-logtimemicros", "-debug", "-debugexclude=libevent", "-debugexclude=leveldb", "-mocktime=" + str(mocktime), "-uacomment=testnode%d" % i] 66 | + self.args = [self.binary, "-datadir=" + self.datadir, "-logtimemicros", "-debug", "-debugexclude=libevent", "-debugexclude=leveldb", "-mocktime=" + str(mocktime), "-uacomment=testnode%d" % i]
BTW, why not move -logtimemicros and -debug* to conf (all static parameters really)?
I think when you later spin up a node for debugging the datadir (block state, wallet state), you don't need to log micro time stamps. Also, I am not sure how the debug flags interfere when the conf sets -debug and the command line -nodebug ... Better leave it up for the user to set those explicitly, I think?
That's reasonable, thanks.
utACK face722.
@MarcoFalke I think this is ready for merge, but you might want to respond to @promag's comment