Interrupt block generation on shutdown request #12448

pull promag wants to merge 1 commits into bitcoin:master from promag:2018-02-interrupt-generate-blocks changing 1 files +1 −1
  1. promag commented at 1:03 pm on February 16, 2018: member
    With this simple change, after running bitcoin-cli -regtest generate 100000, it is possible to interrupt bitcoind cleanly without waiting for the generation to complete.
  2. rpc: Interrupt block generation on shutdown request 0851a75b5a
  3. laanwj commented at 1:06 pm on February 16, 2018: member

    utACK on the code change, though I’m somewhat skeptical of the usefulness of the ability to interrupt bitcoind cleanly when generating a bizarre number of blocks in regtest mode.

    FWIW these early-outs are all things that ideally need tests as they introduce more (sometimes unexpected) code paths.

  4. laanwj added the label RPC/REST/ZMQ on Feb 16, 2018
  5. jonasschnelli commented at 10:56 am on February 17, 2018: contributor
    utACK 0851a75b5aad7b05a1cfb4a285ddc9e3319f887b
  6. jonasschnelli added the label Mining on Feb 17, 2018
  7. laanwj merged this on Apr 23, 2018
  8. laanwj closed this on Apr 23, 2018

  9. laanwj referenced this in commit 84efa9a0f7 on Apr 23, 2018
  10. promag deleted the branch on Jun 24, 2019
  11. PastaPastaPasta referenced this in commit 38f122675f on Nov 10, 2020
  12. PastaPastaPasta referenced this in commit 40cc9750a7 on Nov 12, 2020
  13. PastaPastaPasta referenced this in commit b784f869f9 on Nov 17, 2020
  14. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-04 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me