With this simple change, after running bitcoin-cli -regtest generate 100000, it is possible to interrupt bitcoind cleanly without waiting for the generation to complete.
Interrupt block generation on shutdown request #12448
pull promag wants to merge 1 commits into bitcoin:master from promag:2018-02-interrupt-generate-blocks changing 1 files +1 −1-
promag commented at 1:03 PM on February 16, 2018: member
-
rpc: Interrupt block generation on shutdown request 0851a75b5a
-
laanwj commented at 1:06 PM on February 16, 2018: member
utACK on the code change, though I'm somewhat skeptical of the usefulness of the ability to interrupt bitcoind cleanly when generating a bizarre number of blocks in regtest mode.
FWIW these early-outs are all things that ideally need tests as they introduce more (sometimes unexpected) code paths.
- laanwj added the label RPC/REST/ZMQ on Feb 16, 2018
-
jonasschnelli commented at 10:56 AM on February 17, 2018: contributor
utACK 0851a75b5aad7b05a1cfb4a285ddc9e3319f887b
- jonasschnelli added the label Mining on Feb 17, 2018
- laanwj merged this on Apr 23, 2018
- laanwj closed this on Apr 23, 2018
- laanwj referenced this in commit 84efa9a0f7 on Apr 23, 2018
- promag deleted the branch on Jun 24, 2019
- PastaPastaPasta referenced this in commit 38f122675f on Nov 10, 2020
- PastaPastaPasta referenced this in commit 40cc9750a7 on Nov 12, 2020
- PastaPastaPasta referenced this in commit b784f869f9 on Nov 17, 2020
- MarcoFalke locked this on Dec 16, 2021
Contributors
Labels