Windows: open debug.log file via Bitcoin-Qt #1247

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Win_open_debug_logfile changing 5 files +81 −1
  1. Diapolo commented at 8:10 PM on May 9, 2012: none

    This adds code to open (display) the debug.log on Windows with the associated application and adds an entry under help in the main menu. I used #ifdef WIN32 to make this active for Windows only!

    addresses #1244

  2. laanwj commented at 5:37 AM on May 10, 2012: member

    Nice!

    • "Open debug.log with the associated application". Will this work by default? What is the default associated application for .log files?
    • Hmm would it make sense to add this as a button (either on the information page or in an extra tab "Logging") on the debug window, instead of a first-class menu option?
  3. Diapolo commented at 5:55 AM on May 10, 2012: none

    @laanwj .log files are opened with notepad.exe per default (if you didn't change the file association) on WinXP, Win Vista and Win7 (see: https://bugs.freenetproject.org/print_bug_page.php?bug_id=3245).

    I thought about a button, too, but came up with the feeling it would be a bad thing to integrate a button for it. If users are familiar with where to find that switch, it is okay to have it, where it's now IMHO. It's somehow related to the debug window, so yes perhaps add a button there AND leave the menu option.

  4. laanwj commented at 6:24 AM on May 10, 2012: member

    Does debug.log open cleanly in notepad? I remember opening log files with it at work, and everything being on one line. So I generally use wordpad.

    The problem that I have with a menu option is that you get multiple "debug XXXX" menu options. I'd like to keep all debug and diagnostics stuff in one central place. It should not be too visible for end users unless they need it (at request of someone providing tech support). This is why I grouped the RPC console with the other debug window. When, later on, someone decides to write a proper log viewer, it certainly should be a tab of the debug window.

    If you do it this way, then "RPC console" should be separate menu option as well... which, I guess, could make sense.

  5. Diapolo commented at 11:35 AM on May 10, 2012: none

    On Win7 it opens without issues, even big logfiles (which take some time) open cleanly.

    Well, then either we should add that "Tools" menu entry or I simply add a button to the information page of the RPC Console window. I would like to get this in to have some test time (if there are other Win-users compiling from Git), so how shall we proceed? Guess the button thing is the faster approach at first...

  6. Diapolo commented at 3:12 PM on May 10, 2012: none
  7. laanwj commented at 3:29 PM on May 10, 2012: member

    Great!

  8. Diapolo commented at 3:38 PM on May 10, 2012: none

    Updated, rabased and ready after a last check from you ;).

  9. Diapolo commented at 6:51 AM on May 11, 2012: none

    Small update, I renamed the 2 open debug logfile functions to better match the current used coding styles and moved on_openDebugLogfileButton_clicked() to the private slots.

  10. laanwj commented at 6:59 AM on May 11, 2012: member

    Just merged a few, seems this needs rebasing now.

  11. Diapolo commented at 7:15 AM on May 11, 2012: none

    Working on fixing the merge-conflicts...

  12. add code to open (display) debug.log on Windows with the associated application and add a button to the Information page in the Debug console 4d3dda5d9f
  13. Diapolo commented at 9:12 AM on May 11, 2012: none

    Rebased and fixed merge-conflicts.

  14. laanwj referenced this in commit 508471bbc0 on May 11, 2012
  15. laanwj merged this on May 11, 2012
  16. laanwj closed this on May 11, 2012

  17. coblee referenced this in commit 5e8002a2c2 on Jul 17, 2012
  18. suprnurd referenced this in commit 7e9ad0e26c on Dec 5, 2017
  19. lateminer referenced this in commit 3e1233cccb on May 6, 2020
  20. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me