This adds code to open (display) the debug.log on Windows with the associated application and adds an entry under help in the main menu. I used #ifdef WIN32 to make this active for Windows only!
addresses #1244
Nice!
@laanwj .log files are opened with notepad.exe per default (if you didn't change the file association) on WinXP, Win Vista and Win7 (see: https://bugs.freenetproject.org/print_bug_page.php?bug_id=3245).
I thought about a button, too, but came up with the feeling it would be a bad thing to integrate a button for it. If users are familiar with where to find that switch, it is okay to have it, where it's now IMHO. It's somehow related to the debug window, so yes perhaps add a button there AND leave the menu option.
Does debug.log open cleanly in notepad? I remember opening log files with it at work, and everything being on one line. So I generally use wordpad.
The problem that I have with a menu option is that you get multiple "debug XXXX" menu options. I'd like to keep all debug and diagnostics stuff in one central place. It should not be too visible for end users unless they need it (at request of someone providing tech support). This is why I grouped the RPC console with the other debug window. When, later on, someone decides to write a proper log viewer, it certainly should be a tab of the debug window.
If you do it this way, then "RPC console" should be separate menu option as well... which, I guess, could make sense.
On Win7 it opens without issues, even big logfiles (which take some time) open cleanly.
Well, then either we should add that "Tools" menu entry or I simply add a button to the information page of the RPC Console window. I would like to get this in to have some test time (if there are other Win-users compiling from Git), so how shall we proceed? Guess the button thing is the faster approach at first...
Great!
Updated, rabased and ready after a last check from you ;).
Small update, I renamed the 2 open debug logfile functions to better match the current used coding styles and moved on_openDebugLogfileButton_clicked() to the private slots.
Just merged a few, seems this needs rebasing now.
Working on fixing the merge-conflicts...
Rebased and fixed merge-conflicts.