Bitcoin-Qt options: change "Window" to "Client"? #1248

issue Diapolo opened this issue on May 9, 2012
  1. Diapolo commented at 8:58 PM on May 9, 2012: none

    @laanwj IMHO the "Start Bitcoin on window system startup" option doesn't fit below "Window". I was thinking if it could fit in "Main", which it does, but I think the best thing would be to rename "Window" into "Client".

    This is self-explaining, all options that are in there are Client-Options and not only options for the Client-Window (and that's how I understand the current wording). I propose to rename the whole WindowOptionsPage stuff into ClientOptionsPage, to make this a whole. I have no problem with creating a pull for this, but at first what do you think?

  2. laanwj commented at 5:29 AM on May 10, 2012: member

    The page is called "Window" on purpose. "Client" could refer to bitcoin client, network client, and so on. It's too general. Window clearly specifies it is about window behavior, whereas "Display" is about displaying things within the client window.

    The "Main" page is for the leftovers, that would be on a page of their own if properly categorized (fee should be under "Sending" or "Transaction", detach database settings should be under "Database" etc...). Start at startup would be about "System". So maybe moving it back to main makes sense.

    On the other hand, window system integration is a kindof window behavior, and the point was moving things OUT of "Main". I'm a bit divided about this, and don't really want to spend too much time thinking about it, as it is only a very minor issue.

  3. Diapolo commented at 5:46 AM on May 10, 2012: none

    You are right about this beeing a minor issue, but as I said I have a bad feeling about "Window" it doesn't make sense under Windows, as even "Start Bitcoin on window system startup" can be missunderstood (Windows - window). I'm fine with moving it back to "Main" and can create that pull, so you can work on higher priority issues.

  4. laanwj commented at 5:52 AM on May 10, 2012: member

    I believe there was a suggestion once to change it to "Start Bitcoin on system login". On most operating systems that is more correct. This also makes it more obvious to move it out of the Window category, as it doesn't even have the w-word in it anymore.

  5. laanwj referenced this in commit e0feedd7ac on May 11, 2012
  6. Diapolo commented at 1:51 PM on May 11, 2012: none

    Closed, because fixed :).

  7. Diapolo closed this on May 11, 2012

  8. coblee referenced this in commit d4d05c1e4b on Jul 17, 2012
  9. suprnurd referenced this in commit 6067896aec on Dec 5, 2017
  10. lateminer referenced this in commit b90b8b2d41 on Jan 22, 2019
  11. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me