[test] Round target fee to 8 decimals in assert_fee_amount #12486

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:round-assert-fee-amount-target-fee changing 1 files +1 −1

kallewoof commented at 4:21 AM on February 20, 2018: member
The output would produce arbitrary number of decimal points, sometimes resulting in 9 decimals:
```
AssertionError: Fee of 0.00000415 BTC too low! (Should be 0.000006175 BTC)
```
The above looks like the expected fee is 6175 sats when in reality it's 618.
kallewoof renamed this:
~~[test] Round target fee to 8 decimals~~
[test] Round target fee to 8 decimals in assert_fee_amount
on Feb 20, 2018

[test] Round target fee to 8 decimals in assert_fee_amount

The output would produce arbitrary number of decimal points, sometimes resulting in 9 decimals:
AssertionError: Fee of 0.00000415 BTC too low! (Should be 0.000006175 BTC)
The above looks like the expected fee is 6175 sats when in reality it's 618.

42e1b5d979

kallewoof force-pushed on Feb 20, 2018
fanquake added the label Tests on Feb 20, 2018
randolf approved
randolf commented at 5:56 AM on February 20, 2018: contributor

Are there other similar places in the code where this kind of change can/should be implemented? (I'm thinking for future Pull Requests.)
kallewoof commented at 6:07 AM on February 20, 2018: member

Probably, yeah. I didn't go hunting for them, just fixed this one as it was in my face (and confused me due to thinking the expected was 10x+ the result).
MarcoFalke commented at 8:14 PM on February 20, 2018: member

utACK 42e1b5d9797b65d3ce13a7cbace15fbedbcd4018
randolf commented at 8:11 AM on February 21, 2018: contributor

@kallewoof I'm glad that you found it and fixed it. :)
laanwj commented at 4:06 PM on February 23, 2018: member

utACK 42e1b5d
laanwj merged this on Feb 23, 2018
laanwj closed this on Feb 23, 2018
laanwj referenced this in commit 8c33961313 on Feb 23, 2018
MarcoFalke referenced this in commit cfebd400ef on Apr 20, 2018
HashUnlimited referenced this in commit b90b926270 on May 13, 2018
kallewoof deleted the branch on Oct 17, 2019
PastaPastaPasta referenced this in commit c68c20522b on Mar 14, 2020
PastaPastaPasta referenced this in commit d18c28d482 on Mar 19, 2020
PastaPastaPasta referenced this in commit 2cc0da4cdb on Mar 21, 2020
PastaPastaPasta referenced this in commit fa59296e74 on Mar 24, 2020
ckti referenced this in commit b0e36e0b1a on Mar 28, 2021
MarcoFalke referenced this in commit 35a31d5f7e on Oct 1, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#23136 test: update fee rate assertion helper in the functional test framework