[Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server #12490

1. 
   jnewbery commented at 2:21 pm on February 20, 2018: member

   The following rpc features were deprecated in V0.17:

   • validateaddress returning wallet information about an address
   • signrawtransaction

   This PR fully removes those features. It can be merged once V0.17 has been branched from master.

2. 
   jnewbery commented at 2:22 pm on February 20, 2018: member

   open-closing this PR so the branch is available to everyone. This ~+ #10762~ should allow server to be built without any dependencies on wallet.

   Will re-open once V0.17 has been branched.

   Edit: #10762 has been merged. I’ve now rebased this on master.

3. jnewbery closed this on Feb 20, 2018

   ---

4. jnewbery renamed this:
   Remove deprecated wallet rpc methods from server
   Remove deprecated wallet rpc features from bitcoin_server
   on Feb 20, 2018
5. MarcoFalke deleted a comment on Feb 20, 2018
6. jnewbery reopened this on Apr 3, 2018

   ---

7. jnewbery force-pushed on Apr 3, 2018
8. jnewbery closed this on Apr 3, 2018

   ---

9. jnewbery reopened this on Aug 6, 2018

   ---

10. jnewbery force-pushed on Aug 6, 2018
11. jnewbery renamed this:
    Remove deprecated wallet rpc features from bitcoin_server
    [DO NOT MERGE UNTI Lv0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server
    on Aug 6, 2018
12. jnewbery renamed this:
    [DO NOT MERGE UNTI Lv0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server
    [DO NOT MERGE UNTIL v0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server
    on Aug 6, 2018
13. 
    jnewbery commented at 3:06 pm on August 6, 2018: member

    rebased
14. jnewbery force-pushed on Aug 6, 2018
15. jnewbery force-pushed on Aug 6, 2018
16. MarcoFalke added the label Wallet on Aug 6, 2018
17. in src/rpc/misc.cpp:69 in 1158febc93 outdated

    72-#endif
    73-        if (ret["address"].isNull()) {
    74-            std::string currentAddress = EncodeDestination(dest);
    75-            ret.pushKV("address", currentAddress);
    76+        CScript scriptPubKey = GetScriptForDestination(dest);
    77+        ret.pushKV("scriptPubKey", HexStr(scriptPubKey.begin(), scriptPubKey.end()));;
    

    ---

    ---

    

    MarcoFalke commented at 5:33 pm on August 6, 2018:

    nit: No need for double semicolon?

    ---

    

    jnewbery commented at 9:06 pm on August 6, 2018:

    thanks. Fixed
18. 
    MarcoFalke commented at 5:34 pm on August 6, 2018: member

    utACK 1158febc93707910d783be863aa05c8f6cfedb2f
19. jnewbery force-pushed on Aug 6, 2018
20. jnewbery renamed this:
    [DO NOT MERGE UNTIL v0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server
    [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server
    on Aug 14, 2018
21. 
    jnewbery commented at 11:06 am on August 14, 2018: member

    V0.17 has been branched. This is ready for review/merge
22. DrahtBot added the label Needs rebase on Aug 27, 2018
23. [rpc] Remove deprecated validateaddress usage. df905e390e
24. [RPC] Remove warning about wallet addresses in createmultisig()

    createmultisig() was updated in V0.16 to not use the wallet. Warning
    text was included to warn the user. Remove that now.

    90c834089a
25. [rpc] Remove deprecated sigrawtransaction rpc method. f7e9e70468
26. jnewbery force-pushed on Aug 27, 2018
27. 
    jnewbery commented at 6:38 pm on August 27, 2018: member

    rebased
28. DrahtBot removed the label Needs rebase on Aug 27, 2018
29. 
    MarcoFalke commented at 7:08 pm on August 29, 2018: member

    re-utACK f7e9e704683be4d6be4c9ea600a479bc02976313
30. 
    promag commented at 0:42 am on September 7, 2018: member

    utACK f7e9e70.
31. MarcoFalke referenced this in commit 4799b0932a on Sep 7, 2018
32. MarcoFalke merged this on Sep 7, 2018
33. MarcoFalke closed this on Sep 7, 2018

    ---

34. 
    ptyx11 commented at 2:08 pm on September 11, 2018: none

    What was the reasoning behind this? It seems unnecessary.
35. 
    achow101 commented at 2:18 pm on September 11, 2018: member

    @ptyx11 This is part of the separation of the wallet from the node. Those RPCs were node RPCs which involved wallet things, so they needed to be removed. They have been deprecated for at least one major version with replacement RPCs already available.
36. deadalnix referenced this in commit 92eafd93e7 on Mar 20, 2020
37. ftrader referenced this in commit 6380b4c592 on May 19, 2020
38. dzutto referenced this in commit cff4d95913 on Aug 30, 2021
39. dzutto referenced this in commit 4ce386c1e9 on Aug 30, 2021
40. PastaPastaPasta referenced this in commit 6d90e71076 on Sep 1, 2021
41. DrahtBot locked this on Sep 8, 2021

Contributors
jnewbery MarcoFalke promag ptyx11 achow101

Labels
Wallet