[script] lint-whitespace: find errors more easily #12572

pull AkioNak wants to merge 1 commits into bitcoin:master from AkioNak:morelinenumber changing 1 files +12 −2

AkioNak commented at 7:56 AM on March 1, 2018: contributor

Before this PR, the linenumber infomaition is output if trailing-space or tab code was found, but the output occurence is only per a file. This PR separates the output timing of file name and line number. As a result, users will find where they need to fix more easily.

example:

git diff

diff --git a/dummy.txt b/dummy.txt
index c0ce4d776..aebbdb88d 100644
--- a/dummy.txt
+++ b/dummy.txt
@@ -1,2 +1,2 @@
-1
-2
+1 
+       2
@@ -8,2 +8,2 @@
-8
-9
+       8
+9

before this PR - Is there "9 " in second line? It may lead to be misunderstood.

This diff appears to have added new lines with trailing whitespace.
The following changes were suspected:

diff --git a/dummy.txt b/dummy.txt
@@ -1,2 +1,2 @@
+1
+9

after this PR

This diff appears to have added new lines with trailing whitespace.
The following changes were suspected:

diff --git a/dummy.txt b/dummy.txt
@@ -1,2 +1,2 @@
+1
@@ -8,2 +8,2 @@
+9

[script] lint-whitespace: improve print linenumber

Before this PR, the linenumber infomaition is output if trailing-space
or tab code was found, but the output occurence is only per a file.
This PR separates the output timing of file name and line number.
As a result, users will find where they need to fix more easily.

0fbed98e42

fanquake added the label Scripts and tools on Mar 1, 2018
AkioNak renamed this:
~~[script] lint-whitespace: improve print linenumber~~
[script] lint-whitespace: find errors more easily
on Mar 2, 2018
AkioNak commented at 10:44 AM on March 2, 2018: contributor

I changed the title to clarify the intention of this PR.
randolf approved
eklitzke approved
eklitzke commented at 4:33 PM on March 10, 2018: contributor

utACK 0fbed98e4202bb458466791e83e4e2fb25250d51
MarcoFalke merged this on Mar 11, 2018
MarcoFalke closed this on Mar 11, 2018
MarcoFalke referenced this in commit d8d9162f5b on Mar 11, 2018
AkioNak deleted the branch on Mar 19, 2018
PastaPastaPasta referenced this in commit 7ef4035f61 on Jun 13, 2020
PastaPastaPasta referenced this in commit df1a5beb21 on Jun 13, 2020
PastaPastaPasta referenced this in commit bf0dab5a26 on Jun 17, 2020
PastaPastaPasta referenced this in commit 9475fe553d on Jun 18, 2020
zkbot referenced this in commit 43ac2062f9 on Oct 28, 2020
zkbot referenced this in commit 84a5830aaa on Nov 9, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels