GUI RPC Console: if there is no current block number available display N/A on totalBlocks label,... #1258

...instead of 0, which can not ever be true

The number reported by peers is actually the highest block height they have available, and this can in fact be 0 (the genesis block has number 0).

That said, N/A is probably better UI-wise.

That's a fact I didn't know ... but it looks kind of weird to display 0. So all nodes have at least the genesis block, which should read 1 as minimum then. How is this handled in the core?

Edit: It would be easy to change the N/A into 1.

No, the genesis block has height 0. getnumofpeers actually returns the median reported height reported peers. This can be 0 if most peers report 0.

But keep this pull as it is; if the number is zero it most likely means there are no peers that reported any meaningful number at all, so N/A makes that clear.

On the testnet it will show 0 before connecting to any peers. On the normal net it defaults to the last checkpoint (so it would only go to 0 if many peers report 0). So this is mostly useful on the testnet.

You are free to take or discard this, as always :).

Nah it's fine, I'll merge it. Tho we should be careful not to introduce too many translation strings in what is effectively a debugging tool.

Uhm, right, of course "N/A" is already in the translation, so that isn't even a valid point here :)