List Accounts Fix (Issue 76) #126

pull lachesis wants to merge 1 commits into bitcoin:master from lachesis:listaccountsfix changing 1 files +3 −1

lachesis commented at 10:37 PM on March 20, 2011: contributor
Addresses from the sending tab in wxGUI's addressbook appear in listaccounts. The RPC will happily return that address even though it isn't yours.

This is a problem when switching from wxGUI to a RPC UI.

Fixed by adding
```
foreach(const PAIRTYPE(string, string)& entry, mapAddressBook)  
   uint160 hash160;
   if(AddressToHash160(entry.first, hash160) && mapPubKeys.count(hash160)) // This address belongs to me
       mapAccountBalances[entry.second] = 0;
```
to make sure that mapAccountBalances doesn't contain any addresses that we don't have in our key list.
Fixed issue 76 -- RPC error where addresses from addressbook's sending tab appear in listaccounts 75ef232861
lachesis closed this on Mar 20, 2011
dexX7 referenced this in commit 3ec33ff8a7 on Sep 15, 2014
sipa referenced this in commit a064934ec0 on Dec 4, 2014
sipa referenced this in commit 87bddb7a3a on Dec 4, 2014
sipa referenced this in commit eb6347679b on Dec 5, 2014
dexX7 referenced this in commit 3a4940ed16 on Jul 9, 2015
rebroad referenced this in commit 4b7bf01a7d on Dec 7, 2016
deadalnix referenced this in commit 25d125ec26 on Jan 19, 2017
jtimon referenced this in commit 18a6c4df6d on Apr 20, 2017
classesjack referenced this in commit 13e8a3165e on Jan 2, 2018
attilaaf referenced this in commit 3bb7288a18 on Jan 13, 2020
Losangelosgenetics referenced this in commit c431a89ef9 on Mar 12, 2020
rajarshimaitra referenced this in commit 0a117a0497 on Mar 23, 2021
rajarshimaitra referenced this in commit 8caa9ffa3f on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

lachesis

Linked (view graph)

#25323 miniscript fuzzer failing after qa-assets update