Addresses losing accounts #12608

issue theymos opened this issue on March 5, 2018
  1. theymos commented at 11:08 PM on March 5, 2018: none

    There seems to be some sort of bug related to accounts (which I know you intend to deprecate at some point, but still exist). Bitcointalk.org uses the used-to-be-standard accounts pattern of getaccountaddress <account> & getbalance <account>. Upon upgrading from to 0.16.0, it seems that about 10% of addresses given out by getaccountaddress X later do not have their account assignment anymore. They aren't reflected in the getbalance X balance, and the account does not show up in validateaddress.

    I haven't tracked down exactly where the account assignment gets lost. Maybe it's sometimes never made, or maybe it's lost after a while. In some cases, getaccountaddress might've been called twice in quick succession on the same account, so maybe there's a concurrency issue.

    I'm just going to take this opportunity to get rid of accounts usage. Though I suppose that other people will run into this problem, since it was the standard pattern which everyone recommended using from about 2011 to 2015.

  2. jonasschnelli added the label Wallet on Mar 6, 2018
  3. laanwj commented at 6:09 PM on March 6, 2018: member

    Thanks for reporting.

    This is a really strange issue, and somewhat scary, though I agree with your assessment that at this point we should just move forward to remove it.

    If we do want to find the issue here, the only way I can think of to narrow it down would be to bisect to see at which commit it started happening.

  4. MarcoFalke added this to the milestone 0.17.0 on Mar 18, 2018
  5. MarcoFalke removed this from the milestone 0.17.0 on Jul 29, 2018
  6. MarcoFalke added this to the milestone 0.18.0 on Jul 29, 2018
  7. MarcoFalke commented at 5:44 PM on July 29, 2018: member

    Could you check if this also happens with labels, using the 0.17.0 release (not yet released or branched off)

  8. MarcoFalke closed this on Sep 11, 2018

  9. DrahtBot locked this on Sep 8, 2021
Labels

Milestone
0.18.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me