List Accounts Fix (Issue 76) #127

pull lachesis wants to merge 2 commits into bitcoin:master from lachesis:listaccountsfix changing 1 files +5 −2

lachesis commented at 11:55 PM on March 20, 2011: contributor
Addresses from the sending tab in wxGUI's addressbook appear in listaccounts. The RPC will happily return that address even though it isn't yours.

This is a problem when switching from wxGUI to a RPC UI.

Fixed by adding
```
foreach(const PAIRTYPE(string, string)& entry, mapAddressBook)  
   uint160 hash160;
   if(AddressToHash160(entry.first, hash160) && mapPubKeys.count(hash160)) // This address belongs to me
       mapAccountBalances[entry.second] = 0;
```
to make sure that mapAccountBalances doesn't contain any addresses that we don't have in our key list.

My previous request didn't build. whoops Fixed for sure this time.
Fixed issue 76 -- RPC error where addresses from addressbook's sending tab appear in listaccounts 75ef232861
Fixed mistake in previous commit. 27b81110ae
gavinandresen commented at 12:01 AM on April 6, 2011: contributor

I combined the two commits and merged into master.
gavinandresen closed this on Apr 6, 2011
sipa referenced this in commit a064934ec0 on Dec 4, 2014
sipa referenced this in commit 87bddb7a3a on Dec 4, 2014
sipa referenced this in commit eb6347679b on Dec 5, 2014
dexX7 referenced this in commit 374779dbb6 on Jul 10, 2015
rebroad referenced this in commit 1a8c524261 on Dec 7, 2016
deadalnix referenced this in commit d5e8362ae5 on Jan 19, 2017
lateminer referenced this in commit 6ff4e8cf70 on Dec 9, 2017
cryptapus referenced this in commit b52137b8b9 on Jan 3, 2019
attilaaf referenced this in commit 18093c4cef on Jan 13, 2020
Losangelosgenetics referenced this in commit 363a01c611 on Mar 12, 2020
rajarshimaitra referenced this in commit 5b91828174 on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

lachesis

gavinandresen

Linked (view graph)

#25283 Ubuntu 20.04 Server - Build Error #25323 miniscript fuzzer failing after qa-assets update