[Tests] Fix a typo at assert_start_raises_init_error() and use specific exception for initialization error #12810

pull romanz wants to merge 1 commits into bitcoin:master from romanz:fix-blocksdir-test changing 1 files +10 −4

romanz commented at 6:53 AM on March 28, 2018: contributor

self.wait_util_stopped() should be self.wait_until_stopped().

Also, use a specific Exception subclass for indicating node failure to start (instead of using AssetionError and an except Exception clause).

Following https://travis-ci.org/bitcoin/bitcoin/jobs/359066226#L2726 and depending on #12806 (which fixes the root cause of the Travis test failure).
fanquake added the label Tests on Mar 28, 2018
romanz force-pushed on Mar 28, 2018
romanz force-pushed on Mar 28, 2018
romanz force-pushed on Mar 28, 2018
romanz renamed this:
~~[Tests] Fix a typo at assert_start_raises_init_error() and update its invocation~~
[Tests] Fix a typo at assert_start_raises_init_error()
on Mar 28, 2018
randolf changes_requested
randolf commented at 2:02 PM on March 28, 2018: contributor

It appears that you're changing a lot more than just typing errors here. Please update the description of this Pull Request to explain the changes. Thanks.
romanz commented at 3:03 PM on March 28, 2018: contributor

Please update the description of this Pull Request to explain the changes.

Done.
jnewbery commented at 3:12 PM on March 28, 2018: member

Nice change! Please rebase on master now that #12806 is merged, and update the PR title.

[Tests] fix a typo in TestNode.assert_start_raises_init_error()

Also, use specific exception for testing TestNode initialization failure.

8394300859

romanz force-pushed on Mar 28, 2018
romanz renamed this:
~~[Tests] Fix a typo at assert_start_raises_init_error()~~
[Tests] Fix a typo at assert_start_raises_init_error() and use specific exception for initialization error
on Mar 28, 2018
MarcoFalke commented at 4:13 PM on March 28, 2018: member

utACK 8394300859e69141fc62a5c120448f3311e5cc6a
jnewbery commented at 5:13 PM on March 28, 2018: member

Tested ACK 8394300859e69141fc62a5c120448f3311e5cc6a
randolf approved
MarcoFalke merged this on Mar 30, 2018
MarcoFalke closed this on Mar 30, 2018
MarcoFalke referenced this in commit de7e586841 on Mar 30, 2018
romanz deleted the branch on Apr 8, 2018
PastaPastaPasta referenced this in commit e2f56ef531 on Sep 27, 2020
PastaPastaPasta referenced this in commit 27e9990d4d on Oct 22, 2020
PastaPastaPasta referenced this in commit 04b375a95d on Oct 27, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels