contrib: Fix check-doc script regexes #12820

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1803-qaCheckDocRegex changing 2 files +23 −23

MarcoFalke commented at 6:04 PM on March 28, 2018: member
Fixup the regexes to properly find all used args. The regex should now match all of the getter and setter methods of the ArgsManager. See https://dev.visucore.com/bitcoin/doxygen/class_args_manager.html#pub-methods

Before:
```
Args used        : 159
Args documented  : 188
Args undocumented: 0
Args unknown     : 29
```
After:
```
Args used        : 183
Args documented  : 188
Args undocumented: 0
Args unknown     : 5
```
MarcoFalke commented at 6:05 PM on March 28, 2018: member

You can disable the whitespace changes for review (e.g. on GitHub web view with https://github.com/bitcoin/bitcoin/pull/12820/commits/136084470cd7920b94e016621ebf682996247162?w=1)
contrib: Fix check-doc script regexes 136084470c
MarcoFalke force-pushed on Mar 28, 2018
MarcoFalke added the label Scripts and tools on Mar 28, 2018
jnewbery commented at 6:28 PM on March 28, 2018: member

Tested ACK 136084470cd7920b94e016621ebf682996247162

Looks like it works. We can remove the help text for the non-existent -fuzzmessagestest (removed in ea3326891d8c3dcbcff178b618108d657c5586a3)
init: Remove help text for non-existent -fuzzmessagestest arg 0c17e27630
jnewbery commented at 6:55 PM on March 28, 2018: member

Oh, I wasn't suggesting we needed to do it here, but sure why not. Tested ACK 0c17e27630ada2d9284e357cc0e92ffff8775423
meshcollider commented at 9:09 PM on March 28, 2018: contributor

Concept ACK, eventually this script will be unnecessary when the arguments are registered alongside their help text btw
ajtowns commented at 7:27 AM on March 29, 2018: member

Seems pretty reasonable. utACK 0c17e27630ada2d9284e357cc0e92ffff8775423
MarcoFalke merged this on Mar 30, 2018
MarcoFalke closed this on Mar 30, 2018
MarcoFalke referenced this in commit 5e53b80b02 on Mar 30, 2018
MarcoFalke deleted the branch on Mar 30, 2018
PastaPastaPasta referenced this in commit 2c953af85a on Jul 17, 2020
PastaPastaPasta referenced this in commit d26bcfa183 on Jul 17, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels