Trivial: Don't use short version of 'tinyformat/fmt' namespace #12827

pull matthias-g wants to merge 1 commits into bitcoin:master from matthias-g:tinyformat-fmt changing 2 files +3 −3

matthias-g commented at 12:13 PM on March 29, 2018: contributor

As @codablock pointed out in https://github.com/dashpay/dash/pull/1975:

Clion is not able to parse this correctly and messes up all the syntax checks, marking large parts of C++ files as syntactically invalid, making it hard to find real syntax errors without trying compilation.
Trivial: Don't use short version of 'tinyformat/fmt' namespace
because CLion doesn't parse the short version correctly
d218eb921c
fanquake added the label Utils/log/libs on Mar 29, 2018
in src/tinyformat.h:1066 in d218eb921c
```
1062 | @@ -1063,6 +1063,6 @@ std::string format(const std::string &fmt, const Args&... args)
1063 |  
1064 |  } // namespace tinyformat
1065 |  
1066 | -#define strprintf tfm::format
1067 | +#define strprintf tinyformat::format
```
MarcoFalke commented at 12:22 PM on March 29, 2018:

Please submit those changes upstream as well

matthias-g commented at 12:39 PM on March 29, 2018:

The modified line is not part of the upstream tinyformat.h but of the Bitcoin Core additions (see comment in line 1055)
MarcoFalke added the label Refactoring on Mar 29, 2018
laanwj commented at 12:26 PM on March 29, 2018: member

This is correct code, tbh I see no point in changing this. Fix your tool instead.
matthias-g commented at 1:24 PM on March 29, 2018: contributor

Fair enough. Just found that there is already an issue for CLion. Other users, who are affected by this, can use this PR as workaround until the issue is fixed in CLion.
matthias-g closed this on Mar 29, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

matthias-g

MarcoFalke

laanwj

Labels

Refactoring Utils/log/libs