As it says on the tin. Seems there is a mysterious issue on Qt 4.6.2.
Prevent tooltip filter from ever causing infinite loops #1283
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2012_05_prevent_tooltip_infiniteloop changing 1 files +1 −1-
laanwj commented at 7:28 AM on May 13, 2012: member
-
Prevent tooltip filter from ever causing infinite loops 99fdc1d829
-
Diapolo commented at 9:42 AM on May 13, 2012: none
Perhaps it's the time to discontinue support for such an old Qt version? Or at least set a date after which support is taken out?
Of course ACK!
-
laanwj commented at 10:02 AM on May 13, 2012: member
We should drop support once it becomes a large burden. Currently we don't require significant work-arounds to support the old Qts, so it's not a big issue.
-
Diapolo commented at 1:36 PM on May 13, 2012: none
Alright, perhaps it's worth to mention in a source comment this is a Qt 4.6.2 work-around.
-
laanwj commented at 7:44 PM on May 13, 2012: member
Perhaps, though this only makes the condition in which the if() may be entered more explicit.
There's no reason to change this back when dropping support for Qt 4.6.2, which would be the definition of a workaround (such as the #ifdefs).
-
Diapolo commented at 8:02 PM on May 13, 2012: none
ACK, get it in.
- laanwj referenced this in commit 524843af01 on May 13, 2012
- laanwj merged this on May 13, 2012
- laanwj closed this on May 13, 2012
- coblee referenced this in commit 92e097d9af on Jul 17, 2012
- laanwj deleted the branch on Apr 9, 2014
- suprnurd referenced this in commit 5a2a9ccfd5 on Dec 5, 2017
- lateminer referenced this in commit 5e39be7087 on Jan 22, 2019
- DrahtBot locked this on Sep 8, 2021
