rpc: fix type mistmatch in `listreceivedbyaddress` #12837

joemphilips commented at 9:02 AM on March 30, 2018: contributor

txids filed in return value is supposed be string but it was numeric in the help message

fanquake added the label Docs on Mar 30, 2018

fanquake added the label RPC/REST/ZMQ on Mar 30, 2018

in src/wallet/rpcwallet.cpp:1563 in f10504af54 outdated

1559 | @@ -1560,7 +1560,7 @@ UniValue listreceivedbyaddress(const JSONRPCRequest& request)
1560 |              "    \"confirmations\" : n,               (numeric) The number of confirmations of the most recent transaction included\n"
1561 |              "    \"label\" : \"label\",               (string) The label of the receiving address. The default label is \"\".\n"
1562 |              "    \"txids\": [\n"
1563 | -            "       n,                                (numeric) The ids of transactions received with the address \n"
1564 | +            "       txid,                                (string) The ids of transactions received with the address \n"

promag commented at 11:42 AM on March 30, 2018:

Should be \"txid\" and then fix alignment.

promag commented at 11:42 AM on March 30, 2018: member

Could prefix commit message with rpc:

rpc: fix type mistmatch in listreceivedbyaddress 05c03d1249

joemphilips force-pushed on Mar 31, 2018

in src/wallet/rpcwallet.cpp:1563 in 05c03d1249

1559 | @@ -1560,7 +1560,7 @@ UniValue listreceivedbyaddress(const JSONRPCRequest& request)
1560 |              "    \"confirmations\" : n,               (numeric) The number of confirmations of the most recent transaction included\n"
1561 |              "    \"label\" : \"label\",               (string) The label of the receiving address. The default label is \"\".\n"
1562 |              "    \"txids\": [\n"
1563 | -            "       n,                                (numeric) The ids of transactions received with the address \n"
1564 | +            "       \"txid\",                         (string) The ids of transactions received with the address \n"

promag commented at 6:34 PM on April 1, 2018:

Bad alignment.

promag commented at 6:35 PM on April 1, 2018:

Remove whitespace at end of line.

joemphilips commented at 11:14 AM on April 2, 2018:

sorry, I didn't get which part is bad. You mean , should be in the next line?

promag commented at 3:00 PM on April 2, 2018:

Result:
[
  {
    "involvesWatchonly" : true,        (bool) Only returned if imported addresses were involved in transaction
    "address" : "receivingaddress",  (string) The receiving address
    "account" : "accountname",       (string) DEPRECATED. Backwards compatible alias for label.
    "amount" : x.xxx,                  (numeric) The total amount in BTC received by the address
    "confirmations" : n,               (numeric) The number of confirmations of the most recent transaction included
    "label" : "label",               (string) The label of the receiving address. The default label is "".
    "txids": [
       "txid",                         (string) The ids of transactions received with the address
       ...
    ]
  }
  ,...
]

I mean the alignment of the descriptions but there are others that need to be fixed. Just remove the space. (feel free to fix the alignment of the other lines)

MarcoFalke renamed this:
~~fix type mistmatch in `listreceivedbyaddress`~~
rpc: fix type mistmatch in `listreceivedbyaddress`
on Apr 11, 2018

MarcoFalke merged this on Apr 11, 2018

MarcoFalke closed this on Apr 11, 2018

MarcoFalke referenced this in commit 7c06171b3d on Apr 11, 2018

MarcoFalke referenced this in commit 84a09d7f1d on Apr 20, 2018

MarcoFalke referenced this in commit 154f80855a on May 24, 2018

MarcoFalke referenced this in commit b65248e7ee on May 24, 2018

MarcoFalke referenced this in commit a0cb766afd on May 29, 2018

MarcoFalke referenced this in commit bf1f150190 on Jul 12, 2018

HashUnlimited referenced this in commit c16f4e8f9a on Jan 11, 2019

Fabcien referenced this in commit 03bdf2f3ae on Aug 30, 2019

jonspock referenced this in commit 4a86bdb8ab on Dec 8, 2019

jonspock referenced this in commit 04a9d29304 on Dec 8, 2019

proteanx referenced this in commit dda678c712 on Dec 12, 2019

PastaPastaPasta referenced this in commit 884dad7618 on Apr 12, 2020

PastaPastaPasta referenced this in commit 424bbc3425 on Apr 16, 2020

ckti referenced this in commit 0535dde461 on Mar 28, 2021

MarcoFalke locked this on Sep 8, 2021