Trivial: Add logging line in init.cpp that was accidentally removed with #10762 #12845

pull moneyball wants to merge 1 commits into bitcoin:master from moneyball:add_logging_line_to_newer_branch changing 1 files +1 −1

moneyball commented at 8:36 PM on March 30, 2018: contributor

I made the change based off of the DummyWalletInit refactor commit. I can rebase once that is merged.

I built with wallet disabled and debug enabled. I then confirmed in the debug output that the logging line I added back indeed printed.

in src/init.cpp:91 in 208fad6b5e outdated

  87 | @@ -88,7 +88,8 @@ class DummyWalletInit : public WalletInitInterface {
  88 |      void Close() override {}
  89 |  };
  90 |  
  91 | -std::unique_ptr<WalletInitInterface> g_wallet_init_interface(new DummyWalletInit);
  92 | +static DummyWalletInit g_dymmy_wallet_init;

moneyball commented at 10:27 PM on March 30, 2018:

Is this a typo? Should it be g_dummy_wallet_init?

promag commented at 10:51 PM on March 30, 2018: member

Needs rebase.
fanquake added the label Utils/log/libs on Mar 31, 2018
jnewbery commented at 1:44 PM on April 2, 2018: member

This is based on #12836. Will review when that PR is merged/rejected and this PR can be rebased.
moneyball force-pushed on Apr 6, 2018
jnewbery commented at 12:12 PM on April 7, 2018: member

#12845 has been merged. Please rebase!
Christewart commented at 10:13 PM on April 7, 2018: member

tACK 0af6a95
added logging line back that was accidentally removed with #10762 23abfb7b7f
moneyball force-pushed on Apr 9, 2018
jnewbery commented at 9:39 PM on April 9, 2018: member

Tested ACK 23abfb7b7fea6923dc29a9ff1aa958dee83e3bd7
moneyball commented at 9:46 PM on April 9, 2018: contributor
I have rebased to master. I also re-tested as follows:
1. Built with wallet disabled and ensured the logging line added is emitted in debug output
2. Built with wallet enabled and ensure the logging line added is not emitted in debug output
For both of the above configurations, I made sure 'make check' tests passed.
MarcoFalke commented at 11:07 PM on April 9, 2018: member

utACK 23abfb7b7fea6923dc29a9ff1aa958dee83e3bd7
MarcoFalke merged this on Apr 9, 2018
MarcoFalke closed this on Apr 9, 2018
MarcoFalke referenced this in commit 7ee6fc58f8 on Apr 9, 2018
moneyball deleted the branch on Apr 10, 2018
PastaPastaPasta referenced this in commit f22126d858 on Dec 16, 2020
PastaPastaPasta referenced this in commit f256d65e4b on Dec 18, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels