Add P2P, Network, and Qt categories to the desktop icon #12854

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:desktop_categories changing 1 files +1 −1

luke-jr commented at 2:44 AM on April 2, 2018: member

No description provided.
Add P2P, Network, and Qt categories to the desktop icon b63f23c175
meshcollider added the label Linux/Unix on Apr 2, 2018
in contrib/debian/bitcoin-qt.desktop:13 in b63f23c175
```
   9 | @@ -10,5 +10,5 @@ Terminal=false
  10 |  Type=Application
  11 |  Icon=bitcoin128
  12 |  MimeType=x-scheme-handler/bitcoin;
  13 | -Categories=Office;Finance;
  14 | +Categories=Office;Finance;P2P;Network;Qt;
```
laanwj commented at 12:04 PM on April 2, 2018:

I don 't think Qt is a useful category. It's like adding C++. Not relevant to classifying the application. Agree with adding P2P or Network though I'd say one of them is enough (but adding both is fine with me...).

luke-jr commented at 5:24 PM on April 2, 2018:

The Qt category is defined as "Application based on Qt libraries", which certainly applies to bitcoin-qt.

https://specifications.freedesktop.org/menu-spec/latest/apas02.html

laanwj commented at 8:58 AM on April 3, 2018:

Huh, okay. Well if it's part of the standard then ok...
laanwj commented at 8:59 AM on April 3, 2018: member

utACK https://github.com/bitcoin/bitcoin/pull/12854/commits/b63f23c175785450b4665f9fba75cdf64171e236
Sjors commented at 4:13 PM on April 3, 2018: member

Is Debian the only distro supporting this standard?
laanwj commented at 6:37 PM on April 8, 2018: member

freedesktop standards in principle apply to all distributions and window managers. So it would make sense to move it from contrib/debian to a place where make install can install it (not in thie PR though).
laanwj merged this on Apr 10, 2018
laanwj closed this on Apr 10, 2018
laanwj referenced this in commit 5ca1509d6a on Apr 10, 2018
PastaPastaPasta referenced this in commit feb33828dc on Apr 13, 2021
PastaPastaPasta referenced this in commit 3637afddf0 on Apr 17, 2021
kittywhiskers referenced this in commit 8922b5e806 on Apr 23, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels