[tests] Stop feature_block.py from blowing up memory. #12861

1. 
   jnewbery commented at 7:44 pm on April 2, 2018: member

   The new P2PDataStore class was sending full blocks in headers messages, which meant that calls to send_blocks_and_test() would blow up memory if called with a large number of blocks. Fix that by only sending headers in headers messages.

   This means that python should use just over 1GB for feature_block.py (with bitcoind also using just over 1GB). That’s the same as before the feature_block.py refactor.

2. [tests] Stop feature_block.py from blowing up memory.

   The new P2PDataStore class was sending full blocks in headers messages,
   which meant that calls to send_blocks_and_test() would blow up memory if
   called with a large number of blocks. Fix that by only sending headers
   in headers messages.

   89fe5feea2
3. 
   jnewbery commented at 7:44 pm on April 2, 2018: member

   Addresses #11771#pullrequestreview-108201503 and fixes #11773 (comment)
4. 
   MarcoFalke commented at 7:59 pm on April 2, 2018: member

   Tested ACK 89fe5feea21d341c09ed46d16680dc3dad11076e
5. meshcollider added the label Tests on Apr 2, 2018
6. 
   meshcollider commented at 9:05 pm on April 2, 2018: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/12861/commits/89fe5feea21d341c09ed46d16680dc3dad11076e
7. 
   jamesob commented at 9:12 pm on April 2, 2018: member

   utACK https://github.com/bitcoin/bitcoin/pull/12861/commits/89fe5feea21d341c09ed46d16680dc3dad11076e
8. MarcoFalke merged this on Apr 2, 2018
9. MarcoFalke closed this on Apr 2, 2018

   ---

10. MarcoFalke referenced this in commit c564424d98 on Apr 2, 2018
11. jnewbery deleted the branch on Apr 2, 2018
12. 
    ajtowns commented at 10:25 pm on April 2, 2018: member

    Post-merge ACK 89fe5feea21d341c09ed46d16680dc3dad11076e – confirm that fixes the memory error I was seeing.
13. codablock referenced this in commit 8c99b4780c on Sep 30, 2019
14. codablock referenced this in commit 250b45da2c on Sep 30, 2019
15. codablock referenced this in commit 5680f3bdd4 on Oct 2, 2019
16. codablock referenced this in commit e7d424035c on Oct 2, 2019
17. UdjinM6 referenced this in commit 0ce6949b0f on Oct 3, 2019
18. codablock referenced this in commit 67e8c49731 on Oct 3, 2019
19. PastaPastaPasta referenced this in commit 93fb6675db on Jul 19, 2020
20. PastaPastaPasta referenced this in commit d29b8b65d5 on Jul 24, 2020
21. PastaPastaPasta referenced this in commit 2d34722e47 on Jul 27, 2020
22. UdjinM6 referenced this in commit 72bcb166be on Jul 27, 2020
23. UdjinM6 referenced this in commit e9447a123f on Jul 27, 2020
24. MarcoFalke locked this on Sep 8, 2021

Contributors
jnewbery MarcoFalke meshcollider jamesob ajtowns

Labels
Tests