make clean removes src/qt/moc_ files #12870

1. 
   Sjors commented at 1:12 PM on April 3, 2018: member

   Prevents build errors when making e.g. the following switch:

   ./configure
   make
   make clean
   
   ./configure --with-gui=qt4
   make
   

2. make clean removes src/qt/moc_ files 2ebad11cf9
3. fanquake added the label Build system on Apr 3, 2018
4. fanquake requested review from theuni on Apr 3, 2018
5. MarcoFalke added the label GUI on Apr 3, 2018
6. 
   jamesob commented at 8:54 PM on April 3, 2018: member

   Tested ACK https://github.com/bitcoin/bitcoin/pull/12870/commits/2ebad11cf9ec925e4ad75f4520f40b57df4233e5

   Test transcript:

   ./configure ... && make
   find . -name 'moc_*' | wc -l  # verify moc_*s
   make clean
   find . -name 'moc_*' | wc -l  # moc_*s gone
   make clean && ./configure ... && make
   ./src/qt/bitcoin-qt -regtest 
   

7. 
   promag commented at 9:08 PM on April 3, 2018: member

   utACK 2ebad11.

8. 
   sipa commented at 11:18 PM on April 3, 2018: member

   utACK 2ebad11cf9ec925e4ad75f4520f40b57df4233e5

9. jonasschnelli approved
10. 
    jonasschnelli commented at 11:44 AM on April 4, 2018: contributor

    utACK 2ebad11cf9ec925e4ad75f4520f40b57df4233e5

11. jonasschnelli merged this on Apr 4, 2018
12. jonasschnelli closed this on Apr 4, 2018

    ---

13. jonasschnelli referenced this in commit 1d540046fe on Apr 4, 2018
14. Sjors deleted the branch on Apr 4, 2018
15. 
    theuni commented at 11:06 PM on April 4, 2018: member

    This isn't quite right.

    • We avoid using wildcards whenever possible. A 'make clean' should never delete non-project files.
    • qt stuff should be in Makefile.qt.in
    • This should be handled via dependency rather than added as an extra.

    QT_MOC_CPP ends up in CLEAN_QT, which is added to CLEANFILES. Did this not already work as expected?

16. 
    Sjors commented at 7:36 AM on April 5, 2018: member

    make clean left at least one src/qt/moc_* file behind. That said, I can't reproduce it by simply going back to the previous commit on master (b386970d0) and running autogen, configure, make and then make clean.

    It may have been left behind by some other branch* and thus not be covered by QT_MOC_CPP. What's the correct way of handling such a scenario without using wildcards?

    Either way, given that the rm is in the wrong file, this should probably be reverted.

    • = though for this particular working directory none of the branches in git branch added new GUI elements
17. Sjors restored the branch on Apr 5, 2018
18. MarcoFalke added the label Up for grabs on Apr 11, 2018
19. 
    MarcoFalke commented at 11:38 PM on April 11, 2018: member

    Marking "up for grabs", since this needs some fixups.

20. Sjors deleted the branch on Apr 12, 2018
21. Empact referenced this in commit 114958abb0 on May 17, 2018
22. Empact referenced this in commit 4138f42d24 on May 17, 2018
23. MarcoFalke referenced this in commit 092b366881 on May 21, 2018
24. stamhe referenced this in commit 0e8d30a303 on Jun 27, 2018
25. HashUnlimited referenced this in commit 4129610c21 on Sep 7, 2018
26. HashUnlimited referenced this in commit e4bd5c97eb on Sep 7, 2018
27. joemphilips referenced this in commit 740319f372 on Nov 9, 2018
28. MarcoFalke removed the label Up for grabs on Mar 5, 2019
29. PastaPastaPasta referenced this in commit d04ad13799 on Jul 19, 2020
30. PastaPastaPasta referenced this in commit fd7ecfdf6f on Jul 24, 2020
31. PastaPastaPasta referenced this in commit 2cbfa17eeb on Jul 27, 2020
32. UdjinM6 referenced this in commit 09fcfadd34 on Jul 27, 2020
33. UdjinM6 referenced this in commit 1d5e837163 on Jul 27, 2020
34. UdjinM6 referenced this in commit c244676136 on May 21, 2021
35. UdjinM6 referenced this in commit ae4b1e0916 on May 25, 2021
36. DrahtBot locked this on Dec 16, 2021

Review Requested
theuni