update some strings used as warning messages in sendcoinsdialog.cpp #1288

Diapolo commented at 1:41 PM on May 13, 2012: none

No description provided.

laanwj commented at 4:33 PM on May 13, 2012: member

You're trying to break all the translations aren't you? :p

update some strings used as warning messages in sendcoinsdialog.cpp 51ce20d5da

in src/qt/sendcoinsdialog.cpp:None in 5cdfa0f380 outdated

 135 |              QMessageBox::Ok, QMessageBox::Ok);
 136 |          break;
 137 |      case WalletModel::AmountWithFeeExceedsBalance:
 138 |          QMessageBox::warning(this, tr("Send Coins"),
 139 | -            tr("Total exceeds your balance when the %1 transaction fee is included").
 140 | +            tr("Total exceeds your balance when the %1 transaction fee is included.").

laanwj commented at 4:34 PM on May 13, 2012:

Maybe make this "The total" too?

Diapolo commented at 6:19 PM on May 13, 2012:

Agreed!

Diapolo commented at 6:22 PM on May 13, 2012: none

@laanwj I think we should break translations before RC-phase, so yes ... I'm cleaning up ^^.

laanwj commented at 6:27 PM on May 13, 2012: member

I wish there was a way to change the English translation without invalidating all the translated messages... Or at least update the source string for all translations automatically, when there is no substantial difference.

Diapolo commented at 6:31 PM on May 13, 2012: none

This would be a nice thing, but Qts same text heuristic doesn't cover such things.

Edit: All this leads to one thing, take more care if doing strings in the client that need a translations as this is a great plus in terms of UX!

laanwj commented at 7:03 PM on May 13, 2012: member

I think you could actually set the strings as "translation" strings in bitcoin-en.ts instead?

Diapolo commented at 7:21 PM on May 13, 2012: none

Sorry, I don't get it ... can you explain?

laanwj commented at 7:22 PM on May 13, 2012: member

If you open bitcoin-en.ts in Qt translator and set the new messages there, it will change the message shown in English clients without changing the message in the source code, so without affecting the other translations.

Diapolo commented at 7:30 PM on May 13, 2012: none

This would be less invasive, but produce an ugly inconsistency for the en translation-file and the source ... I don't really like that idea. A form of %RPC_Con_Information_Label_text% in the source and translations only in the lang-files, but that would even further raise the complexity.

laanwj commented at 7:37 PM on May 13, 2012: member

I don't like it either. But I also don't like it if 20 translators have to re-translate a message just because a space was removed, or a dot was added, for example.

Transifex also has no way to edit a source message. However, they claim they have "Fussy re-using of existing strings in source language files" with a "similarity threshold" (see http://help.transifex.com/server/releases/1.1.html), so let's hope that helps...

laanwj referenced this in commit a3957d089a on May 13, 2012

laanwj merged this on May 13, 2012

laanwj closed this on May 13, 2012

coblee referenced this in commit f901d5bf94 on Jul 17, 2012

suprnurd referenced this in commit 60409df822 on Dec 5, 2017

DrahtBot locked this on Sep 8, 2021