Minor readability/maintainability changes to warnings.cpp #12912

pull murrayn wants to merge 1 commits into bitcoin:master from murrayn:warnings changing 1 files +15 −6

murrayn commented at 10:10 AM on April 8, 2018: contributor

No description provided.
Minor readability/maintainability changes to warnings.cpp 7357af682c
fanquake added the label Refactoring on Apr 8, 2018
in src/warnings.cpp:54 in 7357af682c
```
  51 | -        strGUI = _("This is a pre-release test build - use at your own risk - do not use for mining or merchant applications");
  52 | +        const char *PRE_RELEASE_MSG =
  53 | +            "This is a pre-release test build - use at your own risk - do not use for "
  54 | +            "mining or merchant applications.";
  55 | +        strStatusBar = PRE_RELEASE_MSG;
  56 | +        strGUI = _(PRE_RELEASE_MSG);
```
MarcoFalke commented at 3:53 PM on April 8, 2018:

Not sure if the changes are worth it. Is this even picked up as a translation that way?

murrayn commented at 7:12 AM on April 10, 2018:

Is your concern with the adjacent string literals? That should not affect translation. Or am I missing something?

laanwj commented at 2:57 PM on April 11, 2018:

Not sure if the changes are worth it. Is this even picked up as a translation that way?

Only stuff physically inside the _() will be picked up by gettext. Never pass variables to it.
MarcoFalke commented at 3:00 PM on April 11, 2018: member

Since this breaks translations and the readability gain is questionable, I'd suggest to close this pull request.
MarcoFalke commented at 3:00 PM on April 11, 2018: member

Closing for now. Let me know if someone disagrees.
MarcoFalke closed this on Apr 11, 2018
murrayn deleted the branch on Apr 13, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels