qa: Windows fixups for functional tests #12917

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1804-qaWinFixups changing 2 files +7 −7
  1. MarcoFalke commented at 4:48 PM on April 8, 2018: member

    Just two minor fixups to have less errors when the tests run on native windows.

    • Strip whitespace from lines when reading from a notification file
    • Instead of clumsily creating a file with weird permissions, just create a folder for the same effect in mempool_persist.py
  2. qa: Windows fixups for functional tests fab9095d40
  3. MarcoFalke commented at 4:52 PM on April 8, 2018: member

    The failure for removing the file with weird permissions: PermissionError: [WinError 5] Access is denied: 'C:\\Users\\b\\AppData\\Local\\Temp\\1\\bitcoin_test_runner_20180318_140545\\mempool_persist_445\\node1\\regtest\\mempool.dat.new' and the failure in notifications:

    AssertionError: not([
    '0de8e8bb3d20037e2d8590a7da3016592f42d857aae4db6cf4ec19ad168ae6bb', 
    '392fd1853324a63fe4a3f84c2dafbb204f608d91f48c7b093fb459cc7ec60fe3', 
    '39b07286b19d08e0c14528289663864a466dd53b921d08845c99f8aa6bbe6aa7', 
    '45e541f38d93565297f4a1c1538e4623efdec4cf73d4d08884ca0d5d29b773cb', 
    '47216f1684c46d870d98890bc258ea1e46b10565e093cc77d760f8ffb0928093', 
    '47b7fb4d72de6027173ccc2cb04c7d8432a5f6afc1ee3deecf82d7873724fac8', 
    '4c11025fa0abe62585272aebf08f814ed316d876da6362b2e0964d9431c108ee', 
    '55006dd51e55b96c5eff2e953460a90c43064082020127d7e2eb8cb9de021ac9', 
    '5db418f4eaadfaddde2de6a4f2a4e8b07a1b2b358eae70c320f5ef5050cecc0e', 
    '7012e96c86de31e8c386ad2f88e2f58bd633c43adba4fbaa010acdbee4470401'] == 
    ['0de8e8bb3d20037e2d8590a7da3016592f42d857aae4db6cf4ec19ad168ae6bb ', 
    '392fd1853324a63fe4a3f84c2dafbb204f608d91f48c7b093fb459cc7ec60fe3 ', 
    '39b07286b19d08e0c14528289663864a466dd53b921d08845c99f8aa6bbe6aa7 ', 
    '45e541f38d93565297f4a1c1538e4623efdec4cf73d4d08884ca0d5d29b773cb ', 
    '47216f1684c46d870d98890bc258ea1e46b10565e093cc77d760f8ffb0928093 ', 
    '47b7fb4d72de6027173ccc2cb04c7d8432a5f6afc1ee3deecf82d7873724fac8 ', 
    '4c11025fa0abe62585272aebf08f814ed316d876da6362b2e0964d9431c108ee ', 
    '55006dd51e55b96c5eff2e953460a90c43064082020127d7e2eb8cb9de021ac9 ', 
    '5db418f4eaadfaddde2de6a4f2a4e8b07a1b2b358eae70c320f5ef5050cecc0e ', 
    '7012e96c86de31e8c386ad2f88e2f58bd633c43adba4fbaa010acdbee4470401 '])
    
  4. MarcoFalke added the label Tests on Apr 8, 2018
  5. laanwj commented at 1:29 PM on April 9, 2018: member

    utACK https://github.com/bitcoin/bitcoin/pull/12917/commits/fab9095d4071159f88eeefa5c1a750960fd2fbb9

    I suspect the extra whitespace on windows is the carriage return \r they add before newlines.

  6. MarcoFalke merged this on Apr 9, 2018
  7. MarcoFalke closed this on Apr 9, 2018

  8. MarcoFalke referenced this in commit cf8073f8d1 on Apr 9, 2018
  9. MarcoFalke deleted the branch on Apr 9, 2018
  10. PastaPastaPasta referenced this in commit 386d21d3b6 on Dec 21, 2019
  11. PastaPastaPasta referenced this in commit 909de93b4c on Dec 21, 2019
  12. PastaPastaPasta referenced this in commit b6241550dd on Jan 1, 2020
  13. PastaPastaPasta referenced this in commit fc3ddd8714 on Jan 2, 2020
  14. PastaPastaPasta referenced this in commit 5798971a46 on Jan 2, 2020
  15. PastaPastaPasta referenced this in commit e4b0ee60a4 on Jan 2, 2020
  16. PastaPastaPasta referenced this in commit 7d75e6f524 on Jan 2, 2020
  17. PastaPastaPasta referenced this in commit 25652f26ad on Jan 2, 2020
  18. PastaPastaPasta referenced this in commit f2d55d2778 on Jan 2, 2020
  19. PastaPastaPasta referenced this in commit 50ea6c719c on Jan 3, 2020
  20. ckti referenced this in commit 2048901fc9 on Mar 28, 2021
  21. UdjinM6 referenced this in commit 9796d73e5a on May 21, 2021
  22. UdjinM6 referenced this in commit 0ce8f8b8b3 on May 21, 2021
  23. UdjinM6 referenced this in commit 09be1c33a8 on May 21, 2021
  24. UdjinM6 referenced this in commit add77dd7b1 on May 22, 2021
  25. kittywhiskers referenced this in commit 8ad3122629 on May 25, 2021
  26. MarcoFalke locked this on Sep 8, 2021
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me