GUI RPC Console: ensure we scroll to the end of the QTextEdit after appending #1297

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:RPCCon_ScrollToEnd changing 2 files +12 −0
  1. Diapolo commented at 6:42 AM on May 14, 2012: none

    No description provided.

  2. laanwj commented at 7:53 AM on May 14, 2012: member

    I'd argue that the current behavior is "normal console behavior":

    • when you are scrolled down, it will scroll down on appended text
    • when you manually scrolled up, it leaves the focus alone until you go to the end again

    Scrolling on append can be annoying when you're reading something in history and it suddenly jumps (currently not an issue as all output is a direct response, but that will change when error/debug output is added).

    If you want to add automatic scrolling to the end, do it when the user entered a command. This is similar to gnome-terminal etc.

  3. Diapolo commented at 8:03 AM on May 14, 2012: none

    In Windows the behaviour on the cmd-prompt is to scroll down, even if you manually scrolled up and that's what I was missing here. I understand your hint, that it get's annoying, when messages are appended automatically.

    Scrolling to the end after the user entered a command looks kind of ugly, as you only see the entered command then, but not the output. But I will rework this, to consider auto-messages!

  4. laanwj commented at 8:14 AM on May 14, 2012: member

    I don't think that's true. Have you tried it? If you scroll down after the user command, I think the internal logic of qtextedit will make sure it stays at the end when the reply comes.

  5. Diapolo commented at 8:21 AM on May 14, 2012: none

    @laanwj To be more clear, I was referring to a WIndows command prompt, not the RPC Console, when I talked about what I as Win-user expect from such a RPC Console ;), sorry.

  6. ensure we scroll to the end of the QTextEdit after appending (only for user initiated messages and replies) 780bdb3088
  7. Diapolo commented at 8:48 AM on May 14, 2012: none

    Updated to only do this for non MC_ERROR and MC_DEBUG messages.

  8. laanwj commented at 4:26 PM on May 14, 2012: member

    See #1301 for my take on this...

  9. Diapolo commented at 9:34 PM on May 14, 2012: none

    Fixed by #1301, closing this one!

  10. Diapolo closed this on May 14, 2012

  11. suprnurd referenced this in commit 572c554681 on Dec 5, 2017
  12. lateminer referenced this in commit 00a2337823 on Jan 22, 2019
  13. lateminer referenced this in commit 5e407c71cc on May 6, 2020
  14. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me