No description provided.
GUI RPC Console: ensure we scroll to the end of the QTextEdit after appending #1297
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:RPCCon_ScrollToEnd changing 2 files +12 −0-
Diapolo commented at 6:42 AM on May 14, 2012: none
-
laanwj commented at 7:53 AM on May 14, 2012: member
I'd argue that the current behavior is "normal console behavior":
- when you are scrolled down, it will scroll down on appended text
- when you manually scrolled up, it leaves the focus alone until you go to the end again
Scrolling on append can be annoying when you're reading something in history and it suddenly jumps (currently not an issue as all output is a direct response, but that will change when error/debug output is added).
If you want to add automatic scrolling to the end, do it when the user entered a command. This is similar to gnome-terminal etc.
-
Diapolo commented at 8:03 AM on May 14, 2012: none
In Windows the behaviour on the cmd-prompt is to scroll down, even if you manually scrolled up and that's what I was missing here. I understand your hint, that it get's annoying, when messages are appended automatically.
Scrolling to the end after the user entered a command looks kind of ugly, as you only see the entered command then, but not the output. But I will rework this, to consider auto-messages!
-
laanwj commented at 8:14 AM on May 14, 2012: member
I don't think that's true. Have you tried it? If you scroll down after the user command, I think the internal logic of qtextedit will make sure it stays at the end when the reply comes.
-
ensure we scroll to the end of the QTextEdit after appending (only for user initiated messages and replies) 780bdb3088
-
Diapolo commented at 8:48 AM on May 14, 2012: none
Updated to only do this for non MC_ERROR and MC_DEBUG messages.
- Diapolo closed this on May 14, 2012
- suprnurd referenced this in commit 572c554681 on Dec 5, 2017
- lateminer referenced this in commit 00a2337823 on Jan 22, 2019
- lateminer referenced this in commit 5e407c71cc on May 6, 2020
- DrahtBot locked this on Sep 8, 2021