Reorganize(): remove spurious TxnAbort() #1300

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:extra-abort changing 1 files +0 −1

jgarzik commented at 4:25 PM on May 14, 2012: contributor

If Reorganize() fails, then its caller, CBlock::SetBestChain(), will call TxnAbort().

Redundant TxnAbort() calls are harmless. The second will return an error return value, with no other side effects. TxnAbort() return values are generally never checked. The impact is nil.
jgarzik commented at 7:13 PM on May 19, 2012: contributor

This does not seem to cause problems in testing, but would appreciate some additional eyes on it.

Reorganize(): remove spurious TxnAbort()

If Reorganize() fails, then its caller, CBlock::SetBestChain(),
will call TxnAbort().

Redundant TxnAbort() calls are harmless.  The second will return an
error return value, with no other side effects.  TxnAbort() return
values are generally never checked.  The impact is nil.

b52a270538

jgarzik merged this on May 22, 2012
jgarzik closed this on May 22, 2012
jgarzik deleted the branch on Aug 24, 2014
suprnurd referenced this in commit 3bfa5392fa on Dec 5, 2017
lateminer referenced this in commit a03d9f21bc on Jan 22, 2019
lateminer referenced this in commit 0e3644d531 on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

jgarzik