RPC console: scroll to the end when user enters a command #1301

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2012_05_rpcscrolltoend changing 2 files +11 −1

laanwj commented at 4:26 PM on May 14, 2012: member

Ensures that the command and reply is visible.

My take on #1297, but scrolls to the end after the user executed a command instead of when something is appended, which is more natural to me and prevents annoyances without having to special-case message types.

(By setting the scrollbar to the end, this re-enables auto-scrolling in the widget itself)
RPC console: scroll to the end when user enters a command
- Ensures that the command and reply is visible
5a060b8dc8
Diapolo commented at 4:32 PM on May 14, 2012: none

Are you sure this this works for the CMD_REPLY / CMD_ERROR? Let's say type help, scroll up in the QTextEdit, click in somwhere (perhaps to copy) and type help again. I have a feeling you will see the line where you entered "help", but not the output.
laanwj commented at 4:54 PM on May 14, 2012: member

It really works. I'm pulling off a trick to avoid that. Note that I don't move the cursor :)
Diapolo commented at 5:07 PM on May 14, 2012: none

If it does what I tried to achieve with my pull I'm fine with this one, if it's behaviour is different on Windows I'm a tad unhappy though :). I will test this as soon as it get's merged! Perhaps you can leave my pull open until then.
laanwj referenced this in commit 7dc04f4091 on May 14, 2012
laanwj merged this on May 14, 2012
laanwj closed this on May 14, 2012
coblee referenced this in commit cfdb1a1423 on Jul 17, 2012
lateminer referenced this in commit d965bf8196 on Jan 22, 2019
lateminer referenced this in commit af90f927a0 on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

laanwj

Diapolo

Linked (view graph)

#1297 GUI RPC Console: ensure we scroll to the end of the QTextEdit after appending