[bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. #13030

1. 
   jnewbery commented at 3:21 PM on April 19, 2018: member

   -zapwallettxes should be disallowed when starting bitcoin in multiwallet mode.

   There's code in WalletInit::ParameterInteraction() to disallow -zapwallettxes when running in multiwallet mode. This code functioned as expected when passing the parameter -zapwallettxes=1, but not when passing the parameter -zapwallettxes (ie without the value specified). Fix that and add a test.

   The new test in the [wallet] [tests] Test disallowed multiwallet params commit reproduces the bug and should fail against master.

   Fixes #12505

2. [wallet] Fix zapwallettxes/multiwallet interaction.

   -zapwallettxes should be disallowed when starting bitcoin in multiwallet
   mode.

   3476e3c48b
3. [wallet] [tests] Test disallowed multiwallet params

   Add a test to check that bitcoind fails to start when specifying
   -zapwallettxes, -salvagewallet and -upgradewallet when running in
   multiwallet mode.

   1f838394bf
4. fanquake added the label Wallet on Apr 19, 2018
5. 
   MarcoFalke commented at 3:36 PM on April 19, 2018: member

   utACK 1f83839 (GetBoolArg is also used later on in CreateWalletFromFile)

6. MarcoFalke added this to the milestone 0.16.1 on Apr 19, 2018
7. MarcoFalke added the label Needs backport on Apr 19, 2018
8. 
   laanwj commented at 5:56 PM on April 23, 2018: member

   utACK 1f838394bfd87cc9b28229824568b1d767e8ed6f

9. laanwj merged this on Apr 23, 2018
10. laanwj closed this on Apr 23, 2018

    ---

11. laanwj referenced this in commit d3f04c0e81 on Apr 23, 2018
12. jnewbery deleted the branch on Apr 23, 2018
13. fanquake referenced this in commit 591e925e48 on May 17, 2018
14. fanquake referenced this in commit 939bec0818 on May 17, 2018
15. fanquake removed the label Needs backport on May 17, 2018
16. fanquake referenced this in commit 4c14e7b67c on May 17, 2018
17. fanquake referenced this in commit 8e752c4280 on May 17, 2018
18. fanquake referenced this in commit 5ff571e90c on May 18, 2018
19. laanwj referenced this in commit 50b2c9e0df on May 24, 2018
20. HashUnlimited referenced this in commit 336509cb20 on Jun 29, 2018
21. HashUnlimited referenced this in commit 7e5e054cfe on Jun 29, 2018
22. ccebrecos referenced this in commit 5a5aa1e109 on Sep 14, 2018
23. PastaPastaPasta referenced this in commit 3c4d371aee on Nov 10, 2020
24. PastaPastaPasta referenced this in commit 08d10efd04 on Nov 12, 2020
25. PastaPastaPasta referenced this in commit ca0cdbfbe8 on Nov 17, 2020
26. DrahtBot locked this on Sep 8, 2021

Milestone
0.16.1