[0.16] qa: Backports #13049

1. 
   MarcoFalke commented at 10:52 PM on April 20, 2018: member

   Similar to #12967 this contains all relevant bugfixes and improvements to the functional test suite.

   I didn't include fixes to make the tests run on Windows, since that is still an ongoing effort and doesn't seem worth to backport.

   As all of these are clean cherry-picks, I suggest reviewers redo the cherry-picks to get the same branch and then run the extended test suite.

2. [test] Round target fee to 8 decimals in assert_fee_amount

   The output would produce arbitrary number of decimal points, sometimes resulting in 9 decimals:
   AssertionError: Fee of 0.00000415 BTC too low! (Should be 0.000006175 BTC)
   The above looks like the expected fee is 6175 sats when in reality it's 618.
   
   Github-Pull: #12486
   Rebased-From: 42e1b5d9797b65d3ce13a7cbace15fbedbcd4018

   cfebd400ef
3. test: Use wait_until to ensure ping goes out

   Intermittent failure evident here:
   https://travis-ci.org/bitcoin/bitcoin/jobs/344021180
   
   Github-Pull: #12545
   Rebased-From: 0eb84f30d80847b7392ad42b2d916eaf5923a63c

   1286f3e49a
4. test: Use wait_until in tests where time was used for polling

   Github-Pull: #12553
   Rebased-From: 81b0822772169cb697b5994f49398e619d61a12d

   0e98f96e42
5. [tests] Fix intermittent rpc_net.py failure.

   rpc_net.py would intermittently fail on Travis, probably
   due to assuming that two consecutive RPC calls were atomic.
   Fix this by only testing that amounts are bounded above and
   below rather than equal.
   
   Github-Pull: #12804
   Rebased-From: 5a67c0524e5dc98d0e387f189545bc99863916d4

   4bdb0ce517
6. [tests] Test starting bitcoind with -h and -version

   Github-Pull: #12843
   Rebased-From: 63048ec73d790ecbcfe3186f2520dac4460f56e3

   df38b130d9
7. [qa] Ensure bitcoind processes are cleaned up when tests end

   Github-Pull: #12904
   Rebased-From: e36a0c08529bccc695ec71a7ec1df89367cc1628

   6c26df06ad
8. qa: Cache only chain and wallet for regtest datadir

   Github-Pull: #12638
   Rebased-From: fa2310572f4cfcd3322409ce7e37dde155fc4bc9

   0a76ed232a
9. [qa] Delete cookie file before starting node

   If a cookie file exists in a datadir prior to node startup, it must have
   been leftover from a prior unclean shutdown. As bitcoind will overwrite
   it anyway, delete it before starting up to prevent the test framework
   from inadvertently trying to connect using stale credentials.
   
   Github-Pull: #12902
   Rebased-From: 75d0e4c5444249f0cf81ed0494e2c2717170b695

   7460945e0b
10. qa: Fix python TypeError in script.py

    Github-Pull: #12475
    Rebased-From: fa41d68a2e3f2148c3539a11b61ff835e3141c0d

    41c29f6d1d
11. MarcoFalke added the label Tests on Apr 20, 2018
12. fanquake added this to the milestone 0.16.1 on Apr 22, 2018
13. 
    laanwj commented at 1:51 PM on April 23, 2018: member

    ACK on commit list.

14. fanquake requested review from sdaftuar on Apr 24, 2018
15. MarcoFalke added the label Backport on Apr 24, 2018
16. 
    sdaftuar commented at 1:54 PM on April 24, 2018: member

    ACK

17. sdaftuar approved
18. MarcoFalke merged this on Apr 24, 2018
19. MarcoFalke closed this on Apr 24, 2018

    ---

20. MarcoFalke referenced this in commit 9ea62a3dc4 on Apr 24, 2018
21. MarcoFalke deleted the branch on Apr 24, 2018
22. MarcoFalke locked this on Sep 8, 2021

Milestone
0.16.1