Default -printtoconsole to false for the GUI. GUI programs should not print to the console unnecessarily. For example, when launched by the window manager, the output might end up in the X session log file,
resulting in duplicate logging. On Windows, it is pointless as well because bitcoin-qt isn't a console application.
This same mechanism is used to set -server to true by default for bitcoind: https://github.com/bitcoin/bitcoin/blob/master/src/bitcoind.cpp#L116
(fixes #13004)
Default `-printtoconsole` to false for the GUI. GUI programs should not
print to the console unnecessarily. For example, when launched by the
window manager, the output might end up in the X session log file,
resulting in duplicate logging. On Windows, it is pointless as well
because bitcoin-qt isn't a console application.
I'm not sure if changing the printtoconsole default in #13004 was reasonable. IMO forgetting to pass-in -noprintoconsole during debugging/developing quickly leads to lost data required for debugging.
utACK aee80b0ef9f9e82fb696ca3a05c06f089926bf04.
I'm not sure if changing the printtoconsole default in #13004 was reasonable. IMO forgetting to pass-in -noprintoconsole during debugging/developing quickly leads to lost data required for debugging.
I think it's reasonable: the default (when not -daemon) is to log to both the log file and the console. After #13004 logging to the console no longer implies not logging the file. That's only done when -nodebuglogfile is provided.
utACK aee80b0ef9f9e82fb696ca3a05c06f089926bf04
I stopped seeings logs in bitcoind configured with --no-gui after upgrading to 0.16.1. I'm wondering if this change is to "blame". I don't configure logging in my bitcoin.conf.
Running macOS.
what is --no-gui? As far as I'm aware that's not valid config for bitcoind or the configure script.
In any case, the change in this PR does not affect bitcoind, just bitcoin-qt.
@rikur Please file an issue and provide all the information if you can reproduce.