GUI: adapt user-experience from messagepage for verifymessagedialog #1308

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:polish_verifymessage changing 3 files +72 −66

Diapolo commented at 9:29 PM on May 14, 2012: none
- move placeholderTexts from XML to source to avoid a problem with Qt < 4.7
- add eventFilter for address field to select text when clicking in
- add Clear All button
- rework strings
- use QPushButtons instead of QDialogButtonBox
- use same layout as in messagepage.h for verifymessagedialog.h
It would be nice to discuss the strings once more, before we update the translation master file to not again get strings translated, that are not "final".

I really love that GUI feature and want to thank sje397 for his great work, which I only try to improve a little :).
in src/qt/forms/verifymessagedialog.ui:None in 6a4084a849 outdated
```
  10 | @@ -11,13 +11,13 @@
  11 |     </rect>
  12 |    </property>
  13 |    <property name="windowTitle">
  14 | -   <string>Verify Signed Message</string>
  15 | +   <string>Verify Message Dialog</string>
```
laanwj commented at 5:20 AM on May 15, 2012:

I think "Verify Signed Message" is a good title, which simply states the action. "Dialog" is not a sensible word to end users unless they're UI designers.

Diapolo commented at 6:05 AM on May 15, 2012:

I reverted this change.
laanwj commented at 5:43 AM on May 15, 2012: member

Apart from my small comment, ACK.
adapt user-experience from messagepage / move placeholderTexts from XML to source to avoid a problem with Qt < 4.7 / add eventFilter for address field to select text when clicking in / add Clear All button / rework strings 34aa3112c8
Diapolo commented at 6:05 AM on May 15, 2012: none

Updated and rebased to reflect your comment.
laanwj referenced this in commit 790fe2e558 on May 15, 2012
laanwj merged this on May 15, 2012
laanwj closed this on May 15, 2012
coblee referenced this in commit 8033e8dd28 on Jul 17, 2012
suprnurd referenced this in commit 1486acfb99 on Dec 5, 2017
lateminer referenced this in commit 5266210941 on Jan 22, 2019
lateminer referenced this in commit ca912fc823 on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj