tests: Add test for 64-bit Windows PE, modify 32-bit test results #13094

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:patch-1 changing 1 files +13 −3
  1. ken2812221 commented at 4:44 PM on April 26, 2018: contributor

    9a75d29b6f0d6c4834e451b0fae2200786655a35 change the error result from PIE to DYNAMIC_BASE. And there are no test for 64-bit, so I made one

  2. fanquake added the label Scripts and tools on Apr 26, 2018
  3. laanwj commented at 5:12 PM on April 26, 2018: member

    travis complains about whitespace

    This diff appears to have added new lines with trailing whitespace.
    The following changes were suspected:
    diff --git a/contrib/devtools/test-security-check.py b/contrib/devtools/test-security-check.py
    @@ -57,0 +58,14 @@ class TestSecurityChecks(unittest.TestCase):
    +        self.assertEqual(call_security_check(cc, source, executable, []),
    +        self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat']),
    +        self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--dynamicbase']),
    +        self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--dynamicbase','-Wl,--high-entropy-va']),
    ^---- failure generated from contrib/devtools/lint-whitespace.sh
    
  4. ken2812221 commented at 5:17 PM on April 26, 2018: contributor

    @laanwj I just follow the original format of this file, so should I change this?

  5. laanwj commented at 5:22 PM on April 26, 2018: member

    @ken2812221 Yes, with the trailing whitespace we can't merge it.

  6. tests: Add test for 64-bit PE, modify 32-bit test results
    9a75d29b6f0d6c4834e451b0fae2200786655a35 change the error result from `PIE` to `DYNAMIC_BASE`. And there are no test for 64-bit, so I made one
    ab3f4dd27f
  7. ken2812221 force-pushed on Apr 26, 2018
  8. laanwj commented at 6:29 PM on April 26, 2018: member

    Looks good to me. @theuni can you take a look as well just in case?

  9. fanquake requested review from theuni on May 1, 2018
  10. laanwj merged this on May 7, 2018
  11. laanwj closed this on May 7, 2018

  12. laanwj referenced this in commit bf9b03ddcc on May 7, 2018
  13. ken2812221 deleted the branch on May 7, 2018
  14. theuni commented at 7:31 PM on May 7, 2018: member

    Sorry for missing this one. Post-merge utACK.

  15. deadalnix referenced this in commit 981786527d on Mar 31, 2020
  16. PastaPastaPasta referenced this in commit 1582150faa on Jun 17, 2020
  17. PastaPastaPasta referenced this in commit 34acb29eee on Jun 27, 2020
  18. PastaPastaPasta referenced this in commit 35bc6d7bbf on Jun 28, 2020
  19. PastaPastaPasta referenced this in commit 8a09758298 on Jun 29, 2020
  20. ftrader referenced this in commit 733eb41442 on Aug 17, 2020
  21. MarcoFalke locked this on Sep 8, 2021


theuni


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me