bitcoin exits when -externalip set to onion address #1317

issue rebroad opened this issue on May 15, 2012
  1. rebroad commented at 6:34 PM on May 15, 2012: contributor

    title says it mostly. It exits right after loading the block index (which takes a while these days).

    running v0.6.1-197-gbb361cc-dirty-beta (2012-05-14 11:11:16 -0700)

    error dialog box displayed says "Cannot resolve -externalip address: '7iqjqesnfh4nq2yf.onion'", and the last line in debug.log is "Bound to [::]:8333"

  2. sipa commented at 6:36 PM on May 15, 2012: member

    Not too strange, as onion address support hasn't been merged yet...

  3. rebroad commented at 6:46 PM on May 15, 2012: contributor

    @sipa, uhuh, but surely it shouldn't exit, should it? Just ignore it instead?

  4. sipa commented at 8:11 PM on May 15, 2012: member
    $ ./bitcoind -externalip=blala.onion
    Bitcoin: Cannot resolve -externalip address: 'blala.onion'
    
  5. sipa commented at 8:12 PM on May 15, 2012: member

    With bitcoin-qt, I get a messagebox saying the same thing.

  6. rebroad commented at 8:14 PM on May 15, 2012: contributor

    @sipa - do you think it should exit or continue, ignoring the non-resolvable address? I think the latter would be better.

  7. sipa commented at 8:15 PM on May 15, 2012: member

    As specifying an unresolvable address is most likely the result of a configuration error, I think exiting is the most reasonable thing to do. Whatever happens when we ignore the problem will not be what the user intended.

  8. rebroad commented at 8:16 PM on May 15, 2012: contributor

    @sipa in that case, can it exit before it spends ages loading the block index?

  9. sipa commented at 8:17 PM on May 15, 2012: member

    I'm sure there are improvements possible in the order of initialization and command-line processing.

  10. laanwj commented at 9:25 AM on August 18, 2012: member

    This is expected behavior. Passing invalid input should result in an exit with error message.

  11. laanwj closed this on Aug 18, 2012

  12. suprnurd referenced this in commit 1d45023f3e on Dec 5, 2017
  13. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me