bitcoin exits when -externalip set to onion address #1317

title says it mostly. It exits right after loading the block index (which takes a while these days).

running v0.6.1-197-gbb361cc-dirty-beta (2012-05-14 11:11:16 -0700)

error dialog box displayed says "Cannot resolve -externalip address: '7iqjqesnfh4nq2yf.onion'", and the last line in debug.log is "Bound to [::]:8333"

Not too strange, as onion address support hasn't been merged yet...

@sipa, uhuh, but surely it shouldn't exit, should it? Just ignore it instead?

$ ./bitcoind -externalip=blala.onion
Bitcoin: Cannot resolve -externalip address: 'blala.onion'

With bitcoin-qt, I get a messagebox saying the same thing.

@sipa - do you think it should exit or continue, ignoring the non-resolvable address? I think the latter would be better.

As specifying an unresolvable address is most likely the result of a configuration error, I think exiting is the most reasonable thing to do. Whatever happens when we ignore the problem will not be what the user intended.

@sipa in that case, can it exit before it spends ages loading the block index?

I'm sure there are improvements possible in the order of initialization and command-line processing.

This is expected behavior. Passing invalid input should result in an exit with error message.