[tests] Remove spurious error log in p2p_segwit.py #13205

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:p2p_segwit_remove_spurious_error_log changing 1 files +7 −8
  1. jnewbery commented at 7:53 pm on May 9, 2018: member

    Since 265d7c44b1aae06aee93f745a865807732218a73, when wait_until() fails, an error message is logged to the test framework log. This means that if wait_until() is called inside a try-except with the expectation that it will fail, a spurious error message is logged.

    wait_until() shouldn’t be called with the expectation of failure. Fix that in p2p_segwit.py.

  2. [tests] Remove spurious error log in p2p_segwit.py
    Since 265d7c44b1aae06aee93f745a865807732218a73, when wait_until() fails,
    an error message is logged to the test framework log. This means that if
    wait_until() is called inside a try-except with the expectation that it
    will fail, a spurious error message is logged.
    
    wait_until() shouldn't be called with the expectation of failure. Fix
    that in p2p_segwit.py.
    7384a35849
  3. jnewbery commented at 7:54 pm on May 9, 2018: member
  4. MarcoFalke commented at 8:00 pm on May 9, 2018: member
    utACK 7384a3584929c3650a191d34d09f54e7ec828597
  5. MarcoFalke added the label Tests on May 9, 2018
  6. laanwj commented at 12:02 pm on May 14, 2018: member
    utACK 7384a3584929c3650a191d34d09f54e7ec828597
  7. laanwj merged this on May 14, 2018
  8. laanwj closed this on May 14, 2018

  9. laanwj referenced this in commit 3cbd25f9bf on May 14, 2018
  10. jnewbery deleted the branch on May 14, 2018
  11. TheArbitrator referenced this in commit c972069269 on Jun 9, 2021
  12. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me