wallet rpc: constraints in send* methods #13208

pull kallewoof wants to merge 7 commits into bitcoin:master from kallewoof:feature-sendtoaddress-constraints changing 11 files +390 −69

kallewoof commented at 11:22 AM on May 10, 2018: member
This PR adds a new constraints object to sendtoaddress and sendmany. This currently allows two types of constraints:
- max_inputs=<n>, which restricts the coin selectors to use up to <n> inputs at most
- inputs=[<in1>,...], which forces the coin selectors to use the specified inputs for funding
This lets users do more fine grained coin control from the command line, which was only possible via the GUI previously.
wallet rpc: add new helper function for handling txid/vout dictionaries dd77b5ed29
wallet rpc: lockunspent switch to using new helper function for outpoints db07bc7315
coincontrol: Add m_max_inputs flag 27167924a7
wallet: Abide by max_inputs constraint in coin selection df04df2804
test: Update tests to include new max_input argument d29cb6b0d4
wallet rpc: Add constraints support in send RPC calls 0cfc82849e
fanquake added the label Wallet on May 10, 2018
kallewoof force-pushed on May 11, 2018
test: Add test cases for sending with constraints e96ca3e978
kallewoof force-pushed on May 11, 2018
sipa commented at 6:59 PM on May 11, 2018: member

I think these sort of additions belong more in fundrawtransaction than sendtoaddress and sendmany.
kallewoof commented at 3:13 AM on May 12, 2018: member

Why would I have to manually create a transaction just because I wanted to fine tune the UTXO:s used? (Adding to fundrawtx sounds like a good idea though!)
promag commented at 8:19 AM on May 12, 2018: member

Agree with @sipa, which inputs and other constraints definitely belong to the *rawtransaction calls. Is there a reason to not use those?
kallewoof commented at 9:24 AM on May 12, 2018: member

I guess it makes more sense to keep it in fundrawtransaction. I'll be back. Probably.
kallewoof closed this on May 12, 2018
kallewoof deleted the branch on Oct 17, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels