Help message does not get translated after #13190 #13287

1. 
   ken2812221 commented at 12:50 pm on May 20, 2018: contributor

   In bitcoin-qt, the command line help message should get translated. But after #13190, help message in bitcoin-qt does not get translated to local language.

2. ken2812221 referenced this in commit 69e7c7960f on May 20, 2018
3. 
   ken2812221 commented at 4:08 pm on May 20, 2018: contributor

   There is a problem we need to solve, get -lang option before we translate strings
4. 
   achow101 commented at 8:21 pm on May 20, 2018: member

   This will not be a problem once the translations are updated. After #13190, the context (as in the object that owns the translation) for the translations changed so Qt thinks that the translations are new translations. This will be fixed once the strings are re-translated for the new context which occurs after the translations update.

   There is a problem we need to solve, get -lang option before we translate strings

   There already is one. Strings are only translated for -qt which has a -lang option.

5. 
   ken2812221 commented at 0:28 am on May 21, 2018: contributor

   No, they are not new strings. See src/qt/bitcoin.cpp you initialize the gArgs in step 1, but Qt read the translation resources in step 4.
6. 
   achow101 commented at 2:21 am on May 21, 2018: member

   you initialize the gArgs in step 1, but Qt read the translation resources in step 4.

   Still the translations will not be there because the context has changed. That requires a translation string update to fix.

   You should not just move the arguments setup to after the translator is setup because setting up the translator requires reading a command line argument. Something different needs to be done.

7. jonasschnelli added the label GUI on May 21, 2018
8. ken2812221 closed this on Jun 4, 2018

   ---

9. DrahtBot locked this on Sep 8, 2021

Contributors
ken2812221 achow101

Labels
GUI