Help message does not get translated after #13190 #13287

issue ken2812221 opened this issue on May 20, 2018
  1. ken2812221 commented at 12:50 PM on May 20, 2018: contributor

    <!-- This issue tracker is only for technical issues related to Bitcoin Core. General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com. For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/. If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->

    <!-- Describe the issue -->

    In bitcoin-qt, the command line help message should get translated. But after #13190, help message in bitcoin-qt does not get translated to local language.

    <!--- What behavior did you expect? -->

    <!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->

    <!--- How reliably can you reproduce the issue, what are the steps to do so? -->

    <!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

    <!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

    <!-- Any extra information that might be useful in the debugging process. -->

    <!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

  2. ken2812221 referenced this in commit 69e7c7960f on May 20, 2018
  3. ken2812221 commented at 4:08 PM on May 20, 2018: contributor

    There is a problem we need to solve, get -lang option before we translate strings

  4. achow101 commented at 8:21 PM on May 20, 2018: member

    This will not be a problem once the translations are updated. After #13190, the context (as in the object that owns the translation) for the translations changed so Qt thinks that the translations are new translations. This will be fixed once the strings are re-translated for the new context which occurs after the translations update.

    There is a problem we need to solve, get -lang option before we translate strings

    There already is one. Strings are only translated for -qt which has a -lang option.

  5. ken2812221 commented at 12:28 AM on May 21, 2018: contributor

    No, they are not new strings. See src/qt/bitcoin.cpp you initialize the gArgs in step 1, but Qt read the translation resources in step 4.

  6. achow101 commented at 2:21 AM on May 21, 2018: member

    you initialize the gArgs in step 1, but Qt read the translation resources in step 4.

    Still the translations will not be there because the context has changed. That requires a translation string update to fix.

    You should not just move the arguments setup to after the translator is setup because setting up the translator requires reading a command line argument. Something different needs to be done.

  7. jonasschnelli added the label GUI on May 21, 2018
  8. ken2812221 closed this on Jun 4, 2018

  9. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-03 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me