bench_bitcoin is getting more valuable and it's handy to have around for benchmark comparison. Partially reverts #7776 and #8175
Re-add bench_bitcoin to gitian binaries #13292
pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2018/05/bench_gitian changing 3 files +3 −3-
jonasschnelli commented at 7:59 AM on May 21, 2018: contributor
- jonasschnelli added the label Build system on May 21, 2018
-
MarcoFalke commented at 4:05 PM on May 21, 2018: member
Slightly tend to -0 on shipping the bench binary. I believe the bench is only useful when comparing the output of a code change while keeping itself unchanged. Note that the bench framework changes significantly between releases, so there would be not much value in having it shipped.
I assume your motivation is to ship them on https://bitcoin.jonasschnelli.ch/, in which case I suggest to patch the gitian descriptor locally.
-
jonasschnelli commented at 6:45 PM on May 21, 2018: contributor
I assume your motivation is to ship them on https://bitcoin.jonasschnelli.ch/, in which case I suggest to patch the gitian descriptor locally.
Not only. I was just confronted with comparing different computer systems (mostly barebones) and the bench would have given me first datapoints (for SHA2, etc.).
-
laanwj commented at 6:13 PM on May 23, 2018: member
I'm also ~0 on this. I agree that my original rationale, that bench is useless (at the time it had only one or two tests), no longer holds. Still there's not much point in running it for normal users.
The advantage of adding this has to be balanced against the extra space the extra binary will take up in the distributions.
-
MarcoFalke commented at 7:45 PM on May 23, 2018: member
Not only. I was just confronted with comparing different computer systems (mostly barebones) and the bench would have given me first datapoints (for SHA2, etc.).
Oh, thats a good use case I haven't thought of. Though, in that case you are most likely a sys-admin-kind of person and can compile (or gitian build) from source?
-
sipa commented at 6:10 PM on May 24, 2018: member
No strong opinion, but in general I don't see much value to adding a benchmark (a tool mostly useful for developers) to the release distribution. On the other hand, it also doesn't hurt much.
-
laanwj commented at 4:40 PM on June 5, 2018: member
On the other hand, it also doesn't hurt much.
Interestingly, the bench_bitcoin is larger than bitcoind here (both on Ubuntu 16.04 and 18.04, though these are dynamic executable sizes, the ones in the distribution will be larger as they link boost etc statically):
7,6M src/bench/bench_bitcoin 6,5M src/bitcoind -
MarcoFalke commented at 4:51 PM on June 5, 2018: member
bench includes the 1Mb block?
-
laanwj commented at 6:07 PM on June 7, 2018: member
bench includes the 1Mb block?
Seems like a reasonable explanation. It'd probably add about 11M in that case (to the uncompressed size), in the 0.16.0 archive the
bitcoindexecutable is:-rwxr-xr-x 1 user user 9,8M feb 22 20:19 bitcoind -
Re-add bench_bitcoin to gitian binaries 7f1d638cbc
- jonasschnelli force-pushed on Jun 11, 2018
-
laanwj commented at 4:44 PM on June 24, 2018: member
It looks like there's not much agreement to do this, closing for now.
- laanwj closed this on Jun 24, 2018
-
MarcoFalke commented at 2:41 PM on February 13, 2020: member
fyi, DrahtBot will ship the bench_bitcoin on gitian builds
- DrahtBot locked this on Feb 15, 2022
