[0.16.1] Remaining backports #13317

1. 
   MarcoFalke commented at 5:40 pm on May 24, 2018: member
2. MarcoFalke added the label Backport on May 24, 2018
3. MarcoFalke added this to the milestone 0.16.1 on May 24, 2018
4. Bugfix: ensure consistency of m_failed_blocks after reconsiderblock

   Github-Pull: #13199
   Rebased-From: 11fa6bb66e8c1562305d034903a0dc6aee6eea20

   c71e535aec
5. Do not unlock cs_main in ABC unless we've actually made progress.

   Technically, some internal datastructures may be in an inconsistent
   state if we do this, though there are no known bugs there. Still,
   for future safety, its much better to only unlock cs_main if we've
   made progress (not just tried a reorg which may make progress).
   
   Github-Pull: #13023
   Rebased-From: ecc3c4a019e6db30e208b8554b1a3658dcb9a80a

   0948153ea6
6. Fix concurrency-related bugs in ActivateBestChain

   If multiple threads are invoking ActivateBestChain, it was possible to have
   them working towards different tips, and we could arrive at a less work tip
   than we should.  Fix this by introducing a ChainState lock which must
   be held for the entire duration of ActivateBestChain to enforce
   exclusion in ABC.
   
   Github-Pull: #13023
   Rebased-From: a3ae8e68739023e5dba9e5cb190e707ed4603316

   bb79aaf93a
7. Add unit tests for signals generated by ProcessNewBlock()

   After a recent bug discovered in callback ordering in MainSignals,
   this test checks invariants in ordering of
   BlockConnected / BlockDisconnected / UpdatedChainTip signals
   
   Github-Pull: #13023
   Rebased-From: dd435ad40267f5c50ff17533c696f9302829a6a6

   d6c3a08c48
8. MarcoFalke force-pushed on May 24, 2018
9. Add constant scriptCode policy in non-segwit scripts

   This disables OP_CODESEPARATOR in non-segwit scripts (even in an unexecuted branch), and makes a positive FindAndDelete result invalid. This ensures that the scriptCode serialized in SignatureHash() is always the same as the script passing to the EvalScript.
   
   Github-Pull: #11423
   Rebased-From: 9dabfe49c066301ef75bcfcb089fd308366127c4

   d353dd121b
10. Add transaction tests for constant scriptCode

    Tests showing that CONST_SCRIPTCODE is applied only to non-segwit transactions
    
    Github-Pull: #11423
    Rebased-From: 0f8719bb035187076eeac025e2c786feb0f452d7

    1fffc2b346
11. Policy to reject extremely small transactions

    A transaction with 1 segwit input and 1 P2WPHK output has non-witness size of 82 bytes. Anything smaller than this have unnecessary malloc overhead and are not relayed/mined.
    
    Github-Pull: #11423
    Rebased-From: 7485488e907e236133a016ba7064c89bf9ab6da3

    0a000b9b73
12. qa: Pad scriptPubKeys to get minimum sized txs

    Github-Pull: #11423
    Rebased-From: 364bae5f7a6b16eef63990154e48f19e7e693039

    08334b73be
13. MarcoFalke force-pushed on May 24, 2018
14. laanwj added this to the "For backport" column in a project

    ---

15. fanquake renamed this:
    [0.16.1] Remainig backports
    [0.16.1] Remaining backports
    on May 25, 2018
16. 
    promag commented at 1:25 pm on May 25, 2018: member

    utACK 08334b7.
17. 
    jnewbery commented at 3:16 pm on May 25, 2018: member

    Tested ACK 08334b73be031485a41e2c0647c2df1aa13c6316
18. 
    achow101 commented at 8:15 pm on May 26, 2018: member

    utACK 08334b73be031485a41e2c0647c2df1aa13c6316
19. 
    sipa commented at 1:40 am on May 28, 2018: member

    utACK 08334b73be031485a41e2c0647c2df1aa13c6316
20. 
    laanwj commented at 8:08 am on May 28, 2018: member

    utACK 08334b73be031485a41e2c0647c2df1aa13c6316
21. laanwj merged this on May 28, 2018
22. laanwj closed this on May 28, 2018

    ---

23. laanwj referenced this in commit bfd1e92333 on May 28, 2018
24. fanquake removed this from the "For backport" column in a project

    ---

25. MarcoFalke deleted the branch on May 29, 2018
26. MarcoFalke locked this on Sep 8, 2021

Contributors
MarcoFalke promag jnewbery achow101 sipa laanwj

Labels
Backport

Milestone
0.16.1