Make update-translations.py script check for bitcoin addresses #13363

issue laanwj opened this issue on June 1, 2018
  1. laanwj commented at 9:38 AM on June 1, 2018: member

    Someone on the Russian translation added a bitcoin address into the translation, with the idea of confusing people to send coins there. Luckily no one fell for it, but this could have been different. (was reverted in https://github.com/bitcoin/bitcoin/commit/4ea3e8ef070417ccc22007407d78fa0a41949bee#diff-77c4348ab69f5c434e7b9eda0a655549R66)

    To avoid this, an idea would be to add a check to the contrib/devtools/update-translations.py script that checks each message for valid bitcoin addresses, and warn, as well as drop the message if it encounters one.

    (edit: the "valid" check is not even necessary, I think it would be enough to reject things that look like addresses with a regexp)

  2. laanwj added the label Utils/log/libs on Jun 1, 2018
  3. laanwj added the label good first issue on Jun 1, 2018
  4. laanwj renamed this:
    Make update-translations.py script check for (valid) bitcoin addresses
    Make update-translations.py script check for bitcoin addresses
    on Jun 1, 2018
  5. MarcoFalke added this to the milestone 0.17.0 on Jun 1, 2018
  6. abskj commented at 12:50 AM on June 2, 2018: none

    I would like to work on this

  7. laanwj closed this on Jun 8, 2018

  8. laanwj referenced this in commit 56f69360dc on Jun 8, 2018
  9. UdjinM6 referenced this in commit 22554c7ab9 on Jun 19, 2021
  10. UdjinM6 referenced this in commit a3023c8ec6 on Jun 24, 2021
  11. UdjinM6 referenced this in commit 776694374a on Jun 26, 2021
  12. UdjinM6 referenced this in commit 2469e28de4 on Jun 26, 2021
  13. UdjinM6 referenced this in commit 349c85e1a1 on Jun 26, 2021
  14. PastaPastaPasta referenced this in commit 063d8ad940 on Jun 27, 2021
  15. PastaPastaPasta referenced this in commit b406ba5b97 on Jun 28, 2021
  16. PastaPastaPasta referenced this in commit 2dd83ba60a on Jun 28, 2021
  17. UdjinM6 referenced this in commit 1f537f32f7 on Jun 28, 2021
  18. PastaPastaPasta referenced this in commit 3a4553d99c on Jun 29, 2021
  19. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me