qa: Increase includeconf test coverage #13367

1. 
   MarcoFalke commented at 5:30 pm on June 1, 2018: member

   This adds some missing return false for error conditions and adds test coverage [1] for those.

   Also, extend recursion warning when the chain was set in one of the includeconfs.

   [1] See the red lines in https://marcofalke.github.io/btc_cov/total.coverage/src/util.cpp.gcov.html for missing coverage.

2. qa: Increase includeconf test coverage fa4760fbb3
3. MarcoFalke added the label Tests on Jun 1, 2018
4. 
   MarcoFalke commented at 5:44 pm on June 1, 2018: member

   The recursion warning is a minor esoteric fixup, that can be tested with:

   0$ echo 'includeconf=/tmp/test.conf' > /tmp/bitcoin.conf
   1$ echo 'testnet=1
   2main.includeconf=WARN1
   3test.includeconf=WARN2' > /tmp/test.conf
   4$ ./src/qt/bitcoin-qt -datadir=/tmp  # Run with binary once before, once after my commit
   

5. 
   laanwj commented at 7:28 am on June 4, 2018: member

   Thanks for adding better error handling and tests to argument parsing. utACK fa4760fbb3f1099dcd3c43ebc53c2a761a2170e8
6. ken2812221 referenced this in commit 264efdca74 on Jun 5, 2018
7. laanwj merged this on Jun 5, 2018
8. laanwj closed this on Jun 5, 2018

   ---

9. MarcoFalke deleted the branch on Jun 5, 2018
10. UdjinM6 referenced this in commit dd4c056475 on Jun 19, 2021
11. UdjinM6 referenced this in commit 1e8441b3d9 on Jun 24, 2021
12. UdjinM6 referenced this in commit 789bec3398 on Jun 26, 2021
13. UdjinM6 referenced this in commit 6715982c95 on Jun 26, 2021
14. UdjinM6 referenced this in commit 2c7c4bcc08 on Jun 28, 2021
15. DrahtBot locked this on Sep 8, 2021

Contributors
MarcoFalke laanwj

Labels
Tests