Close #11777
If the HTTP server stopped before it response, then the tests would fail. I think we can just ignore the response error and check if the node has stopped at is_node_stopped.
Tests: Ignore RemoteDisconnected and BadStatusLine when stopping node #13390
pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:stop_node changing 1 files +2 −0-
ken2812221 commented at 1:36 PM on June 4, 2018: contributor
-
Ignore RemoteDisconnected and BadStatusLine when stopping node 0e6871c62e
- fanquake added the label Tests on Jun 4, 2018
-
laanwj commented at 2:00 PM on June 4, 2018: member
I think this is a symptom of an underlying race condition (https://github.com/bitcoin/bitcoin/issues/11777#issuecomment-394364420), so not sure silencing this error is a good idea.
- ken2812221 closed this on Jun 4, 2018
- ken2812221 deleted the branch on Jun 4, 2018
-
laanwj commented at 4:15 PM on June 4, 2018: member
I'm not sure you should close it just because of my comment, without any discussion.
- ken2812221 restored the branch on Jun 4, 2018
-
ken2812221 commented at 4:19 PM on June 4, 2018: contributor
OK, I reopen it.
- ken2812221 reopened this on Jun 4, 2018
-
jnewbery commented at 3:21 PM on June 5, 2018: member
Agree that we shouldn't just swallow this error silently.
If we do decide that it's acceptable for the node to shutdown without responding to a
stopRPC, then the error catching here should be special cased for just thestopcommand (otherwise we'd miss potential bugs where the node doesn't respond to other RPC methods). -
ken2812221 commented at 11:22 PM on June 16, 2018: contributor
Prefer #13485
- ken2812221 closed this on Jun 16, 2018
- ken2812221 deleted the branch on Jun 16, 2018
- DrahtBot locked this on Sep 8, 2021
