Currently, travis only build bitcoin-qt for Mac with make deploy, so I think that we can add a make step to build cli, daemon, test and bench executables.
travis: Change Mac goal to all deploy #13406
pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:travis_make_mac changing 1 files +1 −1-
ken2812221 commented at 12:00 PM on June 6, 2018: contributor
-
ken2812221 commented at 12:01 PM on June 6, 2018: contributor
ref #13235
-
MarcoFalke commented at 4:58 PM on June 6, 2018: member
Just a note that this doesn't time out due to the increase in build time: https://travis-ci.org/MarcoFalke/bitcoin/builds/388818711 (travis build with all caches wiped)
- MarcoFalke assigned theuni on Jun 6, 2018
- MarcoFalke added the label Tests on Jun 6, 2018
- ken2812221 force-pushed on Jun 6, 2018
-
ken2812221 commented at 6:01 PM on June 6, 2018: contributor
Due to travis timeout if there is no cache, so change to another way that just add a new matrix job.
-
MarcoFalke commented at 6:29 PM on June 6, 2018: member
@ken2812221 There was no timeout on the mac job, so your previous solution would be fine. I have deferred this to theuni, since I am not fluent in out build system.
- ken2812221 force-pushed on Jun 6, 2018
-
ken2812221 commented at 6:36 PM on June 6, 2018: contributor
Oh. I just saw the Linux job and misidentified it as Mac job. Thanks for clearifying. So change back to original way.
-
theuni commented at 10:19 PM on June 12, 2018: member
The purpose of "Goal" is that we only build towards that. Unconditionally building all would defeat that purpose.
I think instead, we want to set the mac Goal to
all deploy. - ken2812221 force-pushed on Jun 12, 2018
-
travis: Change Mac goal to all deploy so that travis can build all executables for Mac. 3d69853090
- ken2812221 force-pushed on Jun 12, 2018
- MarcoFalke renamed this:
travis: Add make step so that travis can build all executables for Mac.
travis: Change Mac goal to all deploy
on Jun 12, 2018 -
MarcoFalke commented at 2:48 PM on June 13, 2018: member
utACK 3d69853090a9382fc31b1558a74627f61f002584 Thanks for clarifying @theuni
-
theuni commented at 3:44 PM on June 13, 2018: member
Thanks! utACK 3d69853090a9382fc31b1558a74627f61f002584
- MarcoFalke merged this on Jun 13, 2018
- MarcoFalke closed this on Jun 13, 2018
- MarcoFalke referenced this in commit 4382f192e5 on Jun 13, 2018
- ken2812221 deleted the branch on Jun 13, 2018
- MarcoFalke referenced this in commit 81069a75bd on Jun 15, 2018
- PastaPastaPasta referenced this in commit 35c791c37d on Jul 7, 2020
- PastaPastaPasta referenced this in commit 965d601285 on Jul 7, 2020
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels