The portseed_offset is no longer needed in the test runner, since we already kill leftover processes (see #12904). This "fixes" #10869 because we deterministically pick ports starting at 11000
qa: Remove portseed_offset from test runner #13421
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1806-qaPortseedOffset changing 1 files +1 −5-
MarcoFalke commented at 5:33 PM on June 8, 2018: member
-
qa: Remove portseed_offset from test runner fa6edfef35
- MarcoFalke requested review from jnewbery on Jun 8, 2018
- fanquake added the label Tests on Jun 9, 2018
-
laanwj commented at 12:35 PM on June 11, 2018: member
utACK fa6edfef358518022ee86c0abc77c1c068f106a3 I think making the port range more deterministic is, overall, a good thing. We don't support multiple
test_runnerinstances at the same time, and if we did, it would be better as an explicit option to change the port offset. - laanwj merged this on Jun 11, 2018
- laanwj closed this on Jun 11, 2018
- laanwj referenced this in commit 531a0337ca on Jun 11, 2018
- MarcoFalke deleted the branch on Jun 11, 2018
-
laanwj commented at 1:42 PM on June 11, 2018: member
Something that might be useful is to do an initial sweep over all the ports that are going to be used, so if something is in the way, there's an early warning/error.
- UdjinM6 referenced this in commit 8d22516df1 on Jun 19, 2021
- UdjinM6 referenced this in commit ad11ad8ec5 on Jun 24, 2021
- UdjinM6 referenced this in commit 4fb22e4c31 on Jun 26, 2021
- UdjinM6 referenced this in commit b02642d53f on Jun 26, 2021
- UdjinM6 referenced this in commit 69fd5dee3d on Jun 26, 2021
- UdjinM6 referenced this in commit 05dd5c7079 on Jun 28, 2021
- Fabcien referenced this in commit 3ba5cf0a5e on Jul 8, 2021
- MarcoFalke locked this on Sep 8, 2021