Improve coverage of SHA256 SelfTest code #13438

pull sipa wants to merge 1 commits into bitcoin:master from sipa:201806_selftestsha changing 1 files +80 −28

sipa commented at 7:10 PM on June 11, 2018: member

The existing SelfTest code does not cover the specialized double-SHA256-for-64-byte-inputs transforms added in #13191. Fix this.
theuni commented at 7:18 PM on June 11, 2018: member

utACK 5edb0bc0e52a7be44ec22257e21ec9198f86acbb, assuming the tests actually pass. Thanks!
fanquake added the label Tests on Jun 12, 2018
fanquake added the label Validation on Jun 12, 2018
laanwj commented at 12:51 PM on June 12, 2018: member

slightly tested ACK 5edb0bc0e52a7be44ec22257e21ec9198f86acbb, code looks good, does not seem to add noticable startup time.
DrahtBot commented at 7:00 PM on June 12, 2018: member

Needs rebase
DrahtBot added the label Needs rebase on Jun 12, 2018
Improve coverage of SHA256 SelfTest code 1e1eb6367f
sipa force-pushed on Jun 12, 2018
sipa commented at 7:11 PM on June 12, 2018: member

Rebased.
DrahtBot removed the label Needs rebase on Jun 12, 2018
laanwj commented at 1:35 PM on June 18, 2018: member

re-utACK 1e1eb6367f67dcf968bb62993b98b5873b926fc0
laanwj merged this on Jun 18, 2018
laanwj closed this on Jun 18, 2018
laanwj referenced this in commit 450055bdbd on Jun 18, 2018
codablock referenced this in commit 136765cfa8 on Oct 1, 2019
codablock referenced this in commit e44b6c7e58 on Oct 1, 2019
barrystyle referenced this in commit b2c9a95587 on Jan 22, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels