Win32: use _strnicmp (ISO C++) instead of deprecated strnicmp (POSIX) #1345

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:strnicmp_Win32 changing 2 files +5 −4
  1. Diapolo commented at 9:25 PM on May 17, 2012: none

    See http://msdn.microsoft.com/en-us/library/ms235324%28v=vs.80%29.aspx for reference on _strnicmp.

  2. use _strnicmp (ISO C++) instead of deprecated strnicmp (POSIX) and add missing "#define strncasecmp _strnicmp" in init.cpp f4ac41806a
  3. laanwj commented at 9:32 PM on May 17, 2012: member

    Diapolo you should get a job at Microsoft and get them to remove all those ugly _ from the APIs :)

    ACK

  4. jgarzik commented at 10:53 PM on May 17, 2012: contributor

    it is disappointing that the #define lives in two places, rather than one central location.

  5. jgarzik referenced this in commit c0a360ce49 on May 17, 2012
  6. jgarzik merged this on May 17, 2012
  7. jgarzik closed this on May 17, 2012

  8. Diapolo commented at 10:57 PM on May 17, 2012: none

    At some time we perhaps should introduce something like a special windows header, as there are a few places were there are duplicate WIN32 things used in the code (that IE define for example).

  9. laanwj commented at 11:10 PM on May 17, 2012: member

    Yeah, windows requires a lot of that hand-holding in the form of extra defines / un-defines. It might be worth making a config.h header that includes base OS includes and the necessary voodoo such as defining (u)int_XX types. On the other hand, that can easily grow out of hand into a headers.h-like file again... undoing all the work we did to make different headers for different concerns. This needs careful compromise.

  10. coblee referenced this in commit 06f71ad3b5 on Jul 17, 2012
  11. suprnurd referenced this in commit 1d67d52122 on Dec 5, 2017
  12. lateminer referenced this in commit cdaf6274da on Jan 22, 2019
  13. lateminer referenced this in commit abdc0e762e on May 6, 2020
  14. lateminer referenced this in commit d6298c5fa0 on May 6, 2020
  15. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me