Qt: load wallet in UI after possible init aborts #13506

1. 
   jonasschnelli commented at 7:40 PM on June 19, 2018: contributor

   Bug was introduced in #13063 (80b4910f7d87983f50047074c3c2397b0a5c4e92) where #13097 made possible to get "hit" by that bug. Reported by @ken2812221 (https://github.com/bitcoin/bitcoin/pull/13097#issuecomment-398445833).

   Dynamically loading a wallet informs the UI (and therefore makes the instance accessible) about the new wallet before all possible error cases where handled.

   Easy to reproduce by starting bitcoin-qt --regtest --nowallet -usehd=0 then in the console enter loadwallet wallet.dat.

   This PR will make sure only correctly initialised (loaded) wallets will appear in the UI.

2. Qt: load wallet in UI after possible init aborts 3a03d2a33f
3. jonasschnelli added the label GUI on Jun 19, 2018
4. 
   promag commented at 7:56 PM on June 19, 2018: member

   utACK 3a03d2a.

   Bug was introduced in #13063 (80b4910)

   The bug was already there before #13063, the call to uiInterface.LoadWallet(...) was already premature.

   #13097 made possible to get "hit" by that bug

   :+1:

5. MarcoFalke added this to the milestone 0.17.0 on Jun 19, 2018
6. 
   MarcoFalke commented at 10:05 PM on June 19, 2018: member

   utACK 3a03d2a33fecdc9efc71d3d43ae4980e47e845fe. I believe this is only for 0.17.0?

7. 
   promag commented at 10:08 PM on June 19, 2018: member

   I believe this is only for 0.17.0?

   Yes.

8. ken2812221 approved
9. 
   ken2812221 commented at 2:07 PM on June 20, 2018: contributor

   Tested ACK 3a03d2a33fecdc9efc71d3d43ae4980e47e845fe

10. MarcoFalke merged this on Jun 20, 2018
11. MarcoFalke closed this on Jun 20, 2018

    ---

12. MarcoFalke referenced this in commit 6579d80572 on Jun 20, 2018
13. jasonbcox referenced this in commit 962952f31a on Oct 25, 2019
14. PastaPastaPasta referenced this in commit 5d483106f8 on Dec 16, 2020
15. PastaPastaPasta referenced this in commit ce5b06ed66 on Dec 18, 2020
16. xdustinface referenced this in commit a34ac73dd2 on Apr 4, 2021
17. xdustinface referenced this in commit af40021c9f on Apr 4, 2021
18. xdustinface referenced this in commit 713e241b6f on Apr 4, 2021
19. xdustinface referenced this in commit d84ee328ff on Apr 4, 2021
20. xdustinface referenced this in commit 773e39e1e5 on Apr 5, 2021
21. xdustinface referenced this in commit a8454e22b0 on Apr 13, 2021
22. DrahtBot locked this on Sep 8, 2021

Milestone
0.17.0