Estimatefee prints out incorrect error #13511

Varunram commented at 7:47 PM on June 20, 2018: contributor

estimatefee was removed in v0.17. is the output of bitcoind when we try to use estimatefee, shouldn't it be estimatefee was removed in v0.16?

fanquake added the label RPC/REST/ZMQ on Jun 21, 2018

supersammy7000 commented at 6:08 AM on June 22, 2018: none

You are looking at the master branch which is used for development of the next release i.e. v0.17. This is the v0.16.1 code https://github.com/bitcoin/bitcoin/blob/v0.16.1/src/rpc/mining.cpp#L796 which says estimatefee is deprecated and will be fully removed in v0.17. To use estimatefee in v0.16, restart bitcoind with -deprecatedrpc=estimatefee.

Varunram commented at 12:45 PM on June 22, 2018: contributor

@supersammy7000 https://github.com/bitcoin/bitcoin/commit/ef8340d was merged in 0.16 (not even 0.16.1), so the message has to say deprecated in 0.16 and removed in 0.17 or something similar to avoid confusion.

supersammy7000 commented at 4:06 PM on June 24, 2018: none

If that was the message it could lead you to think the method is still available but it has been removed from the code.

On Fri, Jun 22, 2018, 7:46 AM Varunram Ganesh notifications@github.com wrote:

@supersammy7000 https://github.com/supersammy7000 ef8340d https://github.com/bitcoin/bitcoin/commit/ef8340d was merged in 0.16 (not even 0.16.1), so the message has to say deprecated in 0.16 and removed in 0.17 or something similar to avoid confusion.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/issues/13511#issuecomment-399430435, or mute the thread https://github.com/notifications/unsubscribe-auth/ABoJPcSfvFmANXkKx0i3wdiPf4G1ALQRks5t_OcqgaJpZM4Uv4IC .

Varunram commented at 4:10 PM on June 24, 2018: contributor

I guess the method is still available, it is deprecated which the output don't show. It should be deprecated in 0.16 and removed in 0.17 as pointed out in my last comment.

sipa commented at 4:17 PM on June 24, 2018: member

@Varunram Exactly which version of the source code are you running?

As far as I can see 0.16 has "estimatefee is deprecated and will be fully removed in V0.17" and "To use estimatefee in v0.16, restart bitcoind with -deprecatedrpc=estimatefee."

Master (which will become 0.17) has "estimatefee was removed in 0.17".

All of this looks correct to me.

Varunram commented at 4:54 PM on June 24, 2018: contributor

@sipa Thanks for the reply. I'm running the provided 0.16 binaries at core's website

./bitcoin-cli -regtest estimatefee
error code: -32
error message:
estimatefee was removed in v0.17.
Clients should use estimatesmartfee.

Commit https://github.com/bitcoin/bitcoin/commit/c6f09c2713333bf335e83bb303e2feec10136751 made this change I guess.

But thinking about this for a while, I guess this is technically not an issue now because the next release is 0.17 and the output is accurate anyway for the future release, so I think I should close this issue. (Also, this issue isn't huge in any way) Thanks again!

Varunram closed this on Jun 24, 2018

sipa commented at 5:17 PM on June 24, 2018: member

@Varunram Are you sure you're not running master? Neither 0.16.0 or 0.16.1 even contain the string "estimatefee was removed in v0.17" in the source code. c6f09c2 is in master, but not in v0.16.

Varunram commented at 5:32 PM on June 24, 2018: contributor

Oh dear, looks like my binary is on master, Really sorry sipa and thanks for your time!

MarcoFalke locked this on Sep 8, 2021